Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Images] Bail out when GIF data is in unexpected format instead of crashing #77

Closed
wants to merge 1 commit into from
Closed

[Images] Bail out when GIF data is in unexpected format instead of crashing #77

wants to merge 1 commit into from

Commits on Feb 25, 2015

  1. [Images] Bail out when GIF data is in unexpected format instead of cr… 

    …ashing

When the GIF data is not a string nor NSData, `imageSource` is some unknown value set to whatever memory was on the stack. Calling `CGImageSourceGetType` on it has undefined behavior, and if it makes through to the CFRelease (maybe because it is NULL) then CFRelease will crash. This fixes a clang warning.
    @ide
    ide committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    00ecaa8 View commit details
    Browse the repository at this point in the history