Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link fix on Splash, add TRED. #7862

Closed
wants to merge 2 commits into from
Closed

Link fix on Splash, add TRED. #7862

wants to merge 2 commits into from

Conversation

alexleventer
Copy link
Contributor

Fix the link for Splash, add TRED to React Native app showcase.

Fix link to Splash, add TRED.
@ghost
Copy link

ghost commented May 31, 2016

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 31, 2016
@ghost
Copy link

ghost commented Jun 2, 2016

@alexleventer updated the pull request.

@lacker
Copy link
Contributor

lacker commented Jun 21, 2016

Hey, I changed up the format on the showcase. It would be great to have a listing for Tred though. Maybe this article - http://www.geekwire.com/2015/mobile-dealership-tred-raises-another-1m-to-help-used-car-owners-make-more-money/ with an infoTitle like "Mobile Dealership Tred Raises $1M"? See #8263 for the new format.

@ghost
Copy link

ghost commented Jul 3, 2016

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @lacker as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@hramos
Copy link
Contributor

hramos commented Aug 2, 2016

@alexleventer do you still want to merge this?

@alexleventer
Copy link
Contributor Author

Yea @hramos - updating now

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 2, 2016
@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@hramos
Copy link
Contributor

hramos commented Aug 29, 2016

Ping

@mkonicek
Copy link
Contributor

mkonicek commented Sep 9, 2016

@alexleventer I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment asks a question. I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to add TRED to the showcase.

@mkonicek mkonicek closed this Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants