Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed snapshot test TextExample #8048

Closed
wants to merge 1 commit into from

Conversation

bestander
Copy link
Contributor

@bestander bestander commented Jun 10, 2016

Broken in #7603

This PR generates a new TextExample snapshot.
However I am not sure if it is a fix, needs review

@ghost
Copy link

ghost commented Jun 10, 2016

By analyzing the blame information on this pull request, we identified @grabbou and @nicklockwood to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 10, 2016
@bestander
Copy link
Contributor Author

Closing because the root cause got reverted

@bestander bestander closed this Jun 10, 2016
@bestander bestander reopened this Jun 10, 2016
@bestander
Copy link
Contributor Author

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 10, 2016
@bestander bestander closed this Jun 10, 2016
@bestander bestander deleted the fix-ios-snapshot-test branch June 16, 2016 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant