Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[showcase] Add DN Prio #8055

Closed
wants to merge 2 commits into from
Closed

[showcase] Add DN Prio #8055

wants to merge 2 commits into from

Conversation

olofd
Copy link

@olofd olofd commented Jun 10, 2016

One of Swedens largest newspapers built their latest app in React Native.
http://www.dn.se

(Author of the app here.)

Dagens Nyheter (http://www.dn.se) built one of their apps in React Native.
One of Swedens largest newspapers.
@ghost
Copy link

ghost commented Jun 10, 2016

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@ghost
Copy link

ghost commented Jun 10, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@mkonicek mkonicek changed the title DN Prio Add DN Prio to Showcase Jun 14, 2016
@mkonicek mkonicek changed the title Add DN Prio to Showcase [showcase] Add DN Prio Jun 14, 2016
@ghost
Copy link

ghost commented Jun 14, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2016
@mkonicek
Copy link
Contributor

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 14, 2016
@ghost
Copy link

ghost commented Jun 14, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@mkonicek
Copy link
Contributor

Thanks for choosing React Native! 👍

@ghost
Copy link

ghost commented Jun 15, 2016

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@ghost ghost added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Jun 15, 2016
@mkonicek
Copy link
Contributor

@olofd It looks like this needs rebasing, sorry about that.

@lacker
Copy link
Contributor

lacker commented Jun 21, 2016

Hey, this app looks cool and showcaseworthy but I slightly changed up the format. Sorry for the conflict. Is there something to link to like a newspaper article that covers this app? Or any technical post about building it? See #8263 for the new showcase data format.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@hramos
Copy link
Contributor

hramos commented Aug 2, 2016

@olofd do you still want to merge this?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 2, 2016
@hramos hramos closed this Aug 29, 2016
@olofd olofd mentioned this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants