[Haste] @provides -> @providesModule StaticRenderer #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ide
force-pushed
the
staticrenderer
branch
2 times, most recently
from
070cf60
to
df3ba04
Compare
ide
force-pushed
the
staticrenderer
branch
3 times, most recently
from
7cbe98b
to
927cc4a
Compare
|
@facebook-github-bot import |
Pretty sure this shouldn't be `@provides`, since StaticRenderer is required as a module instead of with `@requires`. =) Test Plan: Ran UIExplorer and flow.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
May 14, 2015
Summary: Pretty sure this shouldn't be @provides Closes facebook#837 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1576511432619372/int_phab to review. |
|
@ide: we found the bug why it didn't update. Should be working fine for old pull requests in a few days (need to make a real diff + land it) |
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
* Update state.md ES6 and new react version does not need super or constructor * Update state.md Added setInterval to componentDidMount, accordance to latest syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure this shouldn't be @provides