Initial stab at NavigationExperimental tutorial #8431
Conversation
|
By analyzing the blame information on this pull request, we identified @caabernathy and @alvaromb to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
There's a few more content edits to go to get more of the Navigator and NavigatorIOS sections in sync with their API references. We may need to break out experimental into its own guide, but I don't want to have a new permalink for NavigationExperimental as the name has not been finalized yet. |
|
Yay! This is great! Looks like this needs a rebase. Btw, did you try to add the React Native Web Player to any of your examples? Or is any navigation not supported by it? |
|
@JoelMarcey That would be ideal, but I don't see any of the navigation APIs in react-native-web. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
@hramos The patch is not applying internally. Might need another rebase -- we can try that. If that doesn't work, we may have to get more creative with an interactive rebase as the merge commit may have caused some possible funkiness here. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
ghost
added
Import Failed
and removed
Import Started
|
@facebook-github-bot shipit |
ghost
added
the
Import Started
|
Rebased, lets see how it goes. |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
It shipped! |
|
Thanks so much for this, I've been using it an app and winging it from examples, this is awesome! |
* Initial stab at NavigationExperimental tutorial Summary: Add a NavigationExperimental section to the Navigation guide.  Closes #8431 Differential Revision: D3493158 Pulled By: JoelMarcey fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e * Change method name color for API/Component methods Summary: Closes #8481 Differential Revision: D3497267 Pulled By: JoelMarcey fbshipit-source-id: 82ffb17a9ec3110481ad64d5065fc9fee6a31808
Summary: Add a NavigationExperimental section to the Navigation guide.  Closes facebook#8431 Differential Revision: D3493158 Pulled By: JoelMarcey fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e
Summary: Add a NavigationExperimental section to the Navigation guide.  Closes facebook#8431 Differential Revision: D3493158 Pulled By: JoelMarcey fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e
Add a NavigationExperimental section to the Navigation guide.