-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added onComplete callback to animation config #8494
added onComplete callback to animation config #8494
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
@@ -1566,6 +1567,16 @@ var modulo = function( | |||
return new AnimatedModulo(a, modulus); | |||
}; | |||
|
|||
const enhanceCallback = (callback: ?EndCallback, config : AnimationConfig) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyword-spacing: Expected space(s) after "if".
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I'm sorry, that's my first PR to react-native, and I'm a bit confused.. I've committed changes required by @eslint-bot . If I understand correctly a new build was not triggered, So I don't have an idea what to do now, to make that proceed. |
b7aa78c
to
d729473
Compare
+1 |
d729473
to
c00b229
Compare
05cf796
to
46edeb0
Compare
46edeb0
to
5f0194a
Compare
@vaukalak I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
5f0194a
to
3e515b4
Compare
@vaukalak updated the pull request - view changes |
1 similar comment
@vaukalak updated the pull request - view changes |
@foghina in base on history, I can find, that you did a lot of contributions in this file. Could you please review this? |
LGTM, will fix a couple of nits before landing. @facebook-github-bot import |
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
@foghina I'm sorry, couldn't understand your comment. Could you please tell me what to do, to make that proceed? |
@vaukalak I just wanted to make a tiny fix (rename Your PR is landing as we speak, no need to do anything :) |
26e8ae7
This fix provides possibility to subscribe to a child animation lifecycle. You'll be able to observe every single animation:
state.someProp
, will updated with'new value'
when the first animation will be completed.