-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Fetch error when debugging in Chrome #8512
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facebook#6679 BTW, why don't we use fetch via node_modules instead of copy/pasting code?
By analyzing the blame information on this pull request, we identified @l-urence to be a potential reviewer. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
labels
Jun 30, 2016
An excellent change! Cheers to you, my friend! |
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
This pull request has been imported. This does not imply the PR has been approved.
and removed
GH Review: review-needed
labels
Jun 30, 2016
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
Jun 30, 2016
034b645
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Fixes facebook#6679 Closes facebook#8512 Differential Revision: D3503958 Pulled By: davidaurelio fbshipit-source-id: 204eaa40832c9acb455f736d0cae40385c67a82f
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Fixes facebook#6679 Closes facebook#8512 Differential Revision: D3503958 Pulled By: donyu fbshipit-source-id: f2102c1051fb3fe1d55ecfa24bed19c8d25224e9
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Fixes facebook#6679 Closes facebook#8512 Differential Revision: D3503958 Pulled By: davidaurelio fbshipit-source-id: 204eaa40832c9acb455f736d0cae40385c67a82f
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Fixes facebook#6679 Closes facebook#8512 Differential Revision: D3503958 Pulled By: donyu fbshipit-source-id: f2102c1051fb3fe1d55ecfa24bed19c8d25224e9
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: Fixes facebook/react-native#6679 Closes facebook/react-native#8512 Differential Revision: D3503958 Pulled By: donyu fbshipit-source-id: f2102c1051fb3fe1d55ecfa24bed19c8d25224e9
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6679
Test Plan:
BTW, why don't we use fetch via node_modules instead of copy/pasting code?