Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.29 cherry-pick: Add post documentation lockdown survey link #8566

Merged
merged 1 commit into from
Jul 5, 2016
Merged

0.29 cherry-pick: Add post documentation lockdown survey link #8566

merged 1 commit into from
Jul 5, 2016

Conversation

JoelMarcey
Copy link

We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs.

This diff adds the survey link to the bottom of each page.

Cherry-pick it into 0.29, which will be the first official release with the new doc content

NOTE: The content via the links in this survey will not be valid until 0.29 is actually released. So I have not enabled the questions for the survey until then.

Test Plan:

http://localhost:8079/react-native/docs/getting-started.html

screenshot 2016-07-01 17 35 17

Summary:
We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs.

This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content

> **NOTE**: The content via the links in this survey will not be valid until 0.29 is actually released. So I have not enabled the questions for the survey until then.

**Test Plan:**

http://localhost:8079/react-native/docs/getting-started.html

<img width="753" alt="screenshot 2016-07-01 17 35 17" src="https://cloud.githubusercontent.com/assets/3757713/16535354/987dd3a8-3fb4-11e6-81b7-1a1fcffd3bb2.png">
Closes #8530

Differential Revision: D3515242

Pulled By: JoelMarcey

fbshipit-source-id: c2d241d472853dfb3f9e7d3ae9560b318aacb866
@ghost
Copy link

ghost commented Jul 4, 2016

By analyzing the blame information on this pull request, we identified @Andreyco and @caabernathy to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 4, 2016
@JoelMarcey JoelMarcey merged commit 85bdc46 into facebook:0.29-stable Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants