Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo #8637

Closed
wants to merge 1 commit into from
Closed

Fixing typo #8637

wants to merge 1 commit into from

Conversation

jgreen01
Copy link

@jgreen01 jgreen01 commented Jul 7, 2016

'iOS' was written but it should be 'Android'.

Fixing typo
961f548 
'iOS' was written when 'Android' was meant
@ghost
Copy link

ghost commented Jul 7, 2016

By analyzing the blame information on this pull request, we identified @JoelMarcey and @lacker to be potential reviewers.

@ghost
Copy link

ghost commented Jul 7, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@JoelMarcey
Copy link

@jgreen82 Thanks for catching this. Just need for you to sign the CLA as mentioned above, then we can merge this in.

@JoelMarcey JoelMarcey self-assigned this Jul 7, 2016
@jgreen01
Copy link
Author

jgreen01 commented Jul 7, 2016

@JoelMarcey we're all good!

@JoelMarcey
Copy link

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 7, 2016
@ghost
Copy link

ghost commented Jul 7, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost
Copy link

ghost commented Jul 7, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2016
@ghost ghost closed this in 6565edc Jul 7, 2016
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@samerce
Fixing typo
85f0a93 
Summary:
'iOS' was written but it should be 'Android'.
Closes facebook#8637

Differential Revision: D3530611

Pulled By: JoelMarcey

fbshipit-source-id: 04dbb2e2188f3de73f9bc185f18950bc5de5607b
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Fixing typo
dd28b79 
Summary:
'iOS' was written but it should be 'Android'.
Closes facebook#8637

Differential Revision: D3530611

Pulled By: JoelMarcey

fbshipit-source-id: 04dbb2e2188f3de73f9bc185f18950bc5de5607b
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2022
Open
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@seraj-ahmad
Fixing typo
15dc313 
Summary:
'iOS' was written but it should be 'Android'.
Closes facebook/react-native#8637

Differential Revision: D3530611

Pulled By: JoelMarcey

fbshipit-source-id: 04dbb2e2188f3de73f9bc185f18950bc5de5607b
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoelMarcey JoelMarcey

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgreen01 @JoelMarcey