Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Fix links from networking to navigation in The Basics. #8698

Closed
wants to merge 2 commits into from
Closed

[Documentation] Fix links from networking to navigation in The Basics. #8698

wants to merge 2 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Jul 11, 2016

Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @grgmo and @lacker to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 11, 2016
@JoelMarcey
Copy link

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 11, 2016
@ghost
Copy link

ghost commented Jul 11, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in b33424e Jul 11, 2016
bestander pushed a commit that referenced this pull request Jul 12, 2016
* Introduce navigators in the tutorial

Summary:
Adds a new section to the tutorial. Covers the basics of scenes and navigators.

The navigator comparison doc has been moved to docs/navigation.html in this PR.

![navigators](https://cloud.githubusercontent.com/assets/165856/16505919/37459e3a-3ed4-11e6-87e9-5fa7e6f792d3.png)
Closes #8515

Differential Revision: D3507325

Pulled By: caabernathy

fbshipit-source-id: e9ee5b2572868189af198cdf461b2728dfa84f9e

* Fix links from networking to navigation in The Basics.

Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes #8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
bestander pushed a commit that referenced this pull request Jul 12, 2016
Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes #8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:
Fixes facebook#8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes facebook#8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
Fixes facebook#8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes facebook#8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes facebook/react-native#8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Networking page links to navigators / next page are broken
4 participants