Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Android testID prop from tag to content-description #8843

Conversation

tuckerconnelly
Copy link
Contributor

@tuckerconnelly tuckerconnelly commented Jul 17, 2016

Fixes #7135

This will make automated tests with Appium possible in Android.

Test plan:

The "Touchable feedback events" section in the UIExplorer has a testID. Checked it in the Appium inspector before, no content-description. Checked it after, it was there:

screen shot 2016-07-16 at 8 25 45 pm

@ghost
Copy link

ghost commented Jul 17, 2016

By analyzing the blame information on this pull request, we identified @kmagiera and @sebmarkbage to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 17, 2016
@janicduplessis
Copy link
Contributor

@bestander Is tag used by other e2e test systems? In this case we might want to set both tag and contentDescription.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2016
@mkonicek
Copy link
Contributor

mkonicek commented Jul 18, 2016

We use the tag in our internal e2e testing system. contentDescription is used for accessibility: https://developer.android.com/training/accessibility/accessible-app.html

You could:

@jsdevel
Copy link
Contributor

jsdevel commented Sep 6, 2016

@mkonicek instead of breaking your e2e tests by using content description, would you accept a PR to leave the existing setter and add an adidtional setter to propagate resource-id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants