Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update yeoman-generator to 0.21 because of RegExp DoS issue #8859

Closed
wants to merge 2 commits into from
Closed

update yeoman-generator to 0.21 because of RegExp DoS issue #8859

wants to merge 2 commits into from

Conversation

hollanderbart
Copy link
Contributor

@hollanderbart hollanderbart commented Jul 18, 2016 •
edited
Loading

Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue.
This MR will update the yeoman-generator version to 0.21.0 to resolve this warning.

@ghost
Copy link

ghost commented Jul 18, 2016

By analyzing the blame information on this pull request, we identified @cpojer and @mkonicek to be potential reviewers.

@ghost
Copy link

ghost commented Jul 18, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 18, 2016
@ghost
Copy link

ghost commented Jul 18, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@hollanderbart
Copy link
Contributor Author

Ammended the commit to rerun the CI (flaky test)

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@satya164
Copy link
Contributor

cc @bestander

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@bestander
Copy link
Contributor

@facebook-github-bot import

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@bestander
Copy link
Contributor

@facebook-github-bot import

@ghost
Copy link

ghost commented Jul 18, 2016

I cannot do that @bestander, because @hollanderbart does not have an active CLA on file.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@bestander
Copy link
Contributor

Ok, some temporary infra fail, should be resolved in a couple of hours

@bestander
Copy link
Contributor

@facebook-github-bot import

@ghost
Copy link

ghost commented Jul 18, 2016

I cannot do that @bestander, because @hollanderbart does not have an active CLA on file.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@fredemmott
Copy link
Contributor

@facebook-github-bot import

@ghost
Copy link

ghost commented Jul 18, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@fredemmott
Copy link
Contributor

@bestander: ping? I just imported this to make sure the bot would, not able to review.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2016
@bestander
Copy link
Contributor

Thanks, Fred, this is on my list

On Tuesday, 19 July 2016, Fred Emmott notifications@github.com wrote:

@bestander https://github.com/bestander: ping? I just imported this to
make sure the bot would, not able to review.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8859 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWFqEbVIJdq2SYWBETPG3s_HsDG7nks5qXCJYgaJpZM4JOgnn
.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2016
@ghost ghost closed this in 25ed41c Jul 19, 2016
@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2016
fadils pushed a commit to fadils/react-native that referenced this pull request Jul 21, 2016
@hollanderbart @fadils
update yeoman-generator to 0.21 because of RegExp DoS issue
589889a 
Summary:
Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is ```npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue```.
This MR will update the yeoman-generator version to 0.21.0 to resolve this warning.
Closes facebook#8859

Reviewed By: matryoshcow

Differential Revision: D3580087

Pulled By: bestander

fbshipit-source-id: 4daddd804679ab8e95e59cf0d0005f87d2f48e1c
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@hollanderbart @samerce
update yeoman-generator to 0.21 because of RegExp DoS issue
a0991ba 
Summary:
Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is ```npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue```.
This MR will update the yeoman-generator version to 0.21.0 to resolve this warning.
Closes facebook#8859

Reviewed By: matryoshcow

Differential Revision: D3580087

Pulled By: bestander

fbshipit-source-id: 4daddd804679ab8e95e59cf0d0005f87d2f48e1c
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@hollanderbart
update yeoman-generator to 0.21 because of RegExp DoS issue
3c4c132 
Summary:
Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is ```npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue```.
This MR will update the yeoman-generator version to 0.21.0 to resolve this warning.
Closes facebook#8859

Reviewed By: matryoshcow

Differential Revision: D3580087

Pulled By: bestander

fbshipit-source-id: 4daddd804679ab8e95e59cf0d0005f87d2f48e1c
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
@bumplzz69 bumplzz69 mentioned this pull request Jun 20, 2023
Open
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@hollanderbart @seraj-ahmad
update yeoman-generator to 0.21 because of RegExp DoS issue
07821ee 
Summary:
Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is ```npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue```.
This MR will update the yeoman-generator version to 0.21.0 to resolve this warning.
Closes facebook/react-native#8859

Reviewed By: matryoshcow

Differential Revision: D3580087

Pulled By: bestander

fbshipit-source-id: 4daddd804679ab8e95e59cf0d0005f87d2f48e1c
@bumplzz69 bumplzz69 mentioned this pull request May 22, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hollanderbart @satya164 @bestander @fredemmott