Add GIF and WebP support specification with Fresco 0.11 #8951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @JoelMarcey and @nicklockwood to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| @@ -34,7 +34,7 @@ const ImageViewManager = NativeModules.ImageViewManager; | |||
| * including network images, static resources, temporary local images, and | |||
| * images from local disk, such as the camera roll. | |||
| * | |||
| * This exmaples shows both fetching and displaying an image from local storage as well as on from | |||
| * This examples shows both fetching and displaying an image from local storage as well as on from | |||
There was a problem hiding this comment.
You fixed 1/2. Can you fix the other 1/2? :)
This should say "This example" -- corrected the misspelling, but it being plural was also wrong.
|
Seems reasonable to me, other than some minor requests for fixes. Thanks! |
ghost
added
the
CLA Signed
charpeni
force-pushed
the
image-documentation-fresco
branch
from
4ecbe23 to
9566260
Compare
|
Oops, you're totally right. Should be fixed now. |
charpeni
force-pushed
the
image-documentation-fresco
branch
from
9566260 to
bf52a1c
Compare
ghost
added
the
CLA Signed
charpeni
force-pushed
the
image-documentation-fresco
branch
from
bf52a1c to
0c14090
Compare
ghost
added
the
CLA Signed
|
Thanks a lot! Didn't realize Fresco split its support for GIFs to a separate library. Good they split up WebP support, it's rarely used. @facebook-github-bot shipit |
ghost
added
CLA Signed
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: Motivation facebook#8455 Fixes facebook#8501 With a bonus fix typo !  Closes facebook#8951 Differential Revision: D3647816 Pulled By: mkonicek fbshipit-source-id: e0349275045cae2922b4bb43bcb99af4c6ef1170
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Motivation facebook#8455 Fixes facebook#8501 With a bonus fix typo !  Closes facebook#8951 Differential Revision: D3647816 Pulled By: mkonicek fbshipit-source-id: e0349275045cae2922b4bb43bcb99af4c6ef1170
Closed
3 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation #8455
Fixes #8501
With a bonus fix typo !