Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onLayout support in <TextInput> for Android (same than iOS fix: #8042) #9113

Closed
wants to merge 1 commit into from
Closed

Fix onLayout support in <TextInput> for Android (same than iOS fix: #8042) #9113

wants to merge 1 commit into from

Conversation

antoinerousseau
Copy link
Contributor

@antoinerousseau antoinerousseau commented Jul 30, 2016

See #8042: exactly the same bug and fix on Android

Test plan

<TextInput onLayout={function(e) { console.log(e.nativeEvent); }} />

@ghost
Copy link

ghost commented Jul 30, 2016

By analyzing the blame information on this pull request, we identified @JoelMarcey and @Bhullnatik to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 30, 2016
@mkonicek
Copy link
Contributor

Thanks a lot!

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 31, 2016
@ghost
Copy link

ghost commented Jul 31, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2016
@ghost ghost closed this in 2ca2f87 Jul 31, 2016
@antoinerousseau antoinerousseau deleted the textinput-onlayout-android branch August 2, 2016 00:34
bartolkaruza pushed a commit to immidi/react-native that referenced this pull request Aug 3, 2016
…acebook#8042)

Summary:
See facebook#8042: exactly the same bug and fix on Android

**Test plan**

```jsx
<TextInput onLayout={function(e) { console.log(e.nativeEvent); }} />
```
Closes facebook#9113

Differential Revision: D3647808

Pulled By: mkonicek

fbshipit-source-id: 252a610e26a72a73411c3407faedea0477bee54e
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
…acebook#8042)

Summary:
See facebook#8042: exactly the same bug and fix on Android

**Test plan**

```jsx
<TextInput onLayout={function(e) { console.log(e.nativeEvent); }} />
```
Closes facebook#9113

Differential Revision: D3647808

Pulled By: mkonicek

fbshipit-source-id: 252a610e26a72a73411c3407faedea0477bee54e
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants