add tintColor and barTintColor to TabBar #961
Conversation
facebook-github-bot
added
the
CLA Signed
| @@ -44,7 +55,10 @@ var styles = StyleSheet.create({ | |||
| }); | |||
|
|
|||
| var config = { | |||
| validAttributes: ReactIOSViewAttributes.UIView, | |||
| validAttributes: merge(ReactIOSViewAttributes.UIView, { | |||
There was a problem hiding this comment.
This is going to conflict with sahrens@58a550f#diff-27f88ff7e26d700f93b6d9791f3d408d
Can you rebase when that lands?
|
I'm looking forward to use this feature |
|
Didn't see that commit landed - I was watching the wrong PR. Should be good to go now @sahrens |
|
@cmcewen can you retry the build on Travis ? maybe with the react-native 0.4.1, the issue will be resolved ;-) |
|
@cmcewen Do you know how fix the failed test ? |
nicklockwood
added
GH Review: needs-revision
and removed
GH Review: review-needed
labels
|
Sorry this has gone unattended for a while. We're still catching up on the backlog. This is basically fine aside from a few stylistic issues. If you can fix those, and rebase against the latest version, we can get this merged. |
|
No worries! I know there's a lot to go through. |
|
@cmatheson Can I help you on anything ? |
|
Can someone please complete this feature? I really need it :-) |
|
Hello @cmcewen @sallar @nicklockwood I rebased @cmcewen work from the master (0.4.4) and by now all the tests pass -> #1337 @cmcewen can you rebase with the master ? else @nicklockwood you can directly merge my PR, it is up to date @cmcewen I not updated your work and neither your "commits", just rebased ;-) |
|
@tsunammis Thanks! I was starting to do it myself, Since I want to use the native tabbar in a project of mine. But will wait for this PR to be merged. |
|
@sallar Like me :) |
Summary: [Origin Pull request](facebook#961) from [cmcewen](https://github.com/cmcewen) All the work have been done by @cmcewen, I just rebased his work with the master. Closes facebook#1337 Github Author: Stan Chollet <stanislas.chollet@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: [Origin Pull request](facebook#961) from [cmcewen](https://github.com/cmcewen) All the work have been done by @cmcewen, I just rebased his work with the master. Closes facebook#1337 Github Author: Stan Chollet <stanislas.chollet@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
…ignore Add .idea to gitignore
No description provided.