-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from Wed 22 Apr #976
Commits on Apr 17, 2015
-
[react-packager] Add asset extensions to file watch glob in the proje…
…ct root
Amjad Masad committedApr 17, 2015 Configuration menu - View commit details
-
Copy full SHA for 2975f26 - Browse repository at this point
Copy the full SHA 2975f26View commit details -
[ReactNative|Easy] Change watchman too-long error message
Summary: @wez Mentioned this in Issue facebook#239 -- right now when watchman takes too long we recommend you run `watchman` from your terminal which actually expects some arguments, so it prints out the following: ``` [pcottle:~/Desktop/react-native:changeErrorMessage]$ watchman { "error": "invalid command (expected an array with some elements!)", "cli_validated": true, "version": "3.0.0" } ``` basically this ends up being more confusing since the command we recommend you run errors out, so lets change it to `watchman version` which at least exists cleanly. I kept the troubleshooting link as https://facebook.github.io/watchman/docs/troubleshooting.html since it sounds like we will update that with the issue people run into in facebook#239 Closes facebook#825 Github Author: Peter Cottle <pcottle@fb.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Configuration menu - View commit details
-
Copy full SHA for 691297a - Browse repository at this point
Copy the full SHA 691297aView commit details -
[Errors] Fix Red Box by fixing providesModule parsing
Summary: cc @amasad An error occurred while trying to display the Red Box since loadSourceMap was not included in the JS bundle. This is because node-haste was treating its docblock as a multiline directive which doesn't make sense for `@providesModule`. In loadSourceMap.js's case, the directive's value was parsed as "loadSourceMap -- disabled flow due to mysterious validation errors --". There are two fixes: add a newline under the `@providesModule` directive, and change the module ID code to look at only the first token of the directive. I opted for the latter so we avoid this class of bugs entirely and AFAIK it's nonsensical to have multiple `@providesModule` values anyway. Closes facebook#866 Github Author: James Ide <ide@jameside.com> Test Plan: Run the packager, trigger an error in an app, see the red box now show up again.
Configuration menu - View commit details
-
Copy full SHA for 0b6dbdb - Browse repository at this point
Copy the full SHA 0b6dbdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbe8e31 - Browse repository at this point
Copy the full SHA dbe8e31View commit details -
[react-packager] Add more information to deprecated asset requires
Amjad Masad committedApr 17, 2015 Configuration menu - View commit details
-
Copy full SHA for f117483 - Browse repository at this point
Copy the full SHA f117483View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for aaaa9a9 - Browse repository at this point
Copy the full SHA aaaa9a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b6d20 - Browse repository at this point
Copy the full SHA 65b6d20View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab1efbd - Browse repository at this point
Copy the full SHA ab1efbdView commit details
Commits on Apr 18, 2015
-
Configuration menu - View commit details
-
Copy full SHA for f3e7511 - Browse repository at this point
Copy the full SHA f3e7511View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17be6ba - Browse repository at this point
Copy the full SHA 17be6baView commit details -
[ReactNative] implement transform styles
Bill Fisher committedApr 18, 2015 Configuration menu - View commit details
-
Copy full SHA for bd5b12c - Browse repository at this point
Copy the full SHA bd5b12cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b9aaac - Browse repository at this point
Copy the full SHA 2b9aaacView commit details -
Configuration menu - View commit details
-
Copy full SHA for ead0f2e - Browse repository at this point
Copy the full SHA ead0f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2186691 - Browse repository at this point
Copy the full SHA 2186691View commit details
Commits on Apr 19, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 0b21df4 - Browse repository at this point
Copy the full SHA 0b21df4View commit details
Commits on Apr 20, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 0e67e33 - Browse repository at this point
Copy the full SHA 0e67e33View commit details -
[react_native] JS files from D2001617: [react_native] Add support for…
… rendering to hardware textures on Android
Configuration menu - View commit details
-
Copy full SHA for fde476f - Browse repository at this point
Copy the full SHA fde476fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb1fa12 - Browse repository at this point
Copy the full SHA fb1fa12View commit details -
Fixed way that ScrollView handles removeClippedSubviews flag
Marek Cirkos committedApr 20, 2015 Configuration menu - View commit details
-
Copy full SHA for 88b6df9 - Browse repository at this point
Copy the full SHA 88b6df9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 915925d - Browse repository at this point
Copy the full SHA 915925dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d5d55d - Browse repository at this point
Copy the full SHA 2d5d55dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbd5259 - Browse repository at this point
Copy the full SHA bbd5259View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6afe1b - Browse repository at this point
Copy the full SHA d6afe1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e2f90a - Browse repository at this point
Copy the full SHA 5e2f90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce9fa4 - Browse repository at this point
Copy the full SHA 5ce9fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e8bc08 - Browse repository at this point
Copy the full SHA 0e8bc08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2434512 - Browse repository at this point
Copy the full SHA 2434512View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a1798 - Browse repository at this point
Copy the full SHA a8a1798View commit details
Commits on Apr 21, 2015
-
[react-packager] Implement Packager::getAssets
Amjad Masad committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for 82704ad - Browse repository at this point
Copy the full SHA 82704adView commit details -
Adds
opaque
andunderlayColor
to WebView.Summary: Enables overwriting of underlying colors for WebViews. Especially useful if you want to give your WebView a transparent background. Closes facebook#767 Github Author: Lochlan Wansbrough <lochie@live.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Configuration menu - View commit details
-
Copy full SHA for 765779a - Browse repository at this point
Copy the full SHA 765779aView commit details -
[react_native] JS files from D2001635: [react_native] Use hardware la…
…yers during adsmanager Navigator navigation
Configuration menu - View commit details
-
Copy full SHA for b0348ed - Browse repository at this point
Copy the full SHA b0348edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e15a0d - Browse repository at this point
Copy the full SHA 8e15a0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0db658 - Browse repository at this point
Copy the full SHA a0db658View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ae548 - Browse repository at this point
Copy the full SHA 25ae548View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee898c2 - Browse repository at this point
Copy the full SHA ee898c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2294da7 - Browse repository at this point
Copy the full SHA 2294da7View commit details -
[react-packager] Allow json files as modules
Amjad Masad committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for 77d908b - Browse repository at this point
Copy the full SHA 77d908bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1351a4 - Browse repository at this point
Copy the full SHA f1351a4View commit details -
[react-packager] bump watchman watch timeout to 10 seconds
Amjad Masad committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for c46c4a0 - Browse repository at this point
Copy the full SHA c46c4a0View commit details -
[react-packager] Add jpe?g to asset extensions
Amjad Masad committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for 173615a - Browse repository at this point
Copy the full SHA 173615aView commit details -
[SliderIOS] Apply value after minimum/maximumValue in order to ensure…
… it is properly set Summary: `value` is clamped between min/max and so order of prop application matters - `value` always ended up being set first in my tests, and consequently a value outside of the default range 0-1 would not work. So this applies the value when the min/max are set. [Gist of broken example](https://gist.github.com/brentvatne/fc637b3e21d012966f3a) ![screenshot](http://url.brentvatne.ca/SQPC.png) ^ the second slider here should have it's cursor in the middle /cc @tadeuzagallo Closes facebook#835 Github Author: Brent Vatne <brent.vatne@madriska.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Brent Vatne committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for 5fb5148 - Browse repository at this point
Copy the full SHA 5fb5148View commit details -
[ReactNative] Navigator touch grant bug from D2001635
Eric Vicenti committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for 45c10ff - Browse repository at this point
Copy the full SHA 45c10ffView commit details -
[react_native] JS files from D2009265: Fix resizeMode for images
Martin Konicek committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for c0c2d4c - Browse repository at this point
Copy the full SHA c0c2d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ad7b8 - Browse repository at this point
Copy the full SHA c6ad7b8View commit details -
[ReactNative] Navigator contextual popToRoute and imperitive vs conte…
…xtual docs
Eric Vicenti committedApr 21, 2015 Configuration menu - View commit details
-
Copy full SHA for 40eeaf5 - Browse repository at this point
Copy the full SHA 40eeaf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32084c9 - Browse repository at this point
Copy the full SHA 32084c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ee7eba - Browse repository at this point
Copy the full SHA 2ee7ebaView commit details
Commits on Apr 22, 2015
-
Summary: The curly braces seems to be redundant. Closes facebook#811 Github Author: xcatliu <xcatliu@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Configuration menu - View commit details
-
Copy full SHA for 404f7d9 - Browse repository at this point
Copy the full SHA 404f7d9View commit details -
Summary: * This PR fixes a typo for the NetInfo docs page Closes facebook#937 Github Author: Mike Wilcox <mwilcox56@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Configuration menu - View commit details
-
Copy full SHA for 17e5b04 - Browse repository at this point
Copy the full SHA 17e5b04View commit details -
Implement XmlHttpRequestBase#getAllResponseHeaders and getResponseHeader
Summary: Used facebook#382 as inspiration but modified to return null instead of undefined as per the spec at https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest This unblocks use of Dropbox.js within a react-native app, as well as any other libraries that make use of these methods in XHR usage. Closes facebook#872 Closes facebook#892 Github Author: Josh Zana <joshzana@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Configuration menu - View commit details
-
Copy full SHA for 368e507 - Browse repository at this point
Copy the full SHA 368e507View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1a1500 - Browse repository at this point
Copy the full SHA b1a1500View commit details -
[Text] Ensure that the text background is transparent by default
Summary: For a very simple view I was observing that the text background was black and had to manually be set to transparent. This ensures that text nodes have a transparent background by default. Closes facebook#256 Github Author: James Ide <ide@jameside.com> Test Plan: This example component no longer renders what looks like a black block, and instead displays legible text. var Example = React.createClass({ render: function() { return ( <View style={styles.container}> <Text>hello</Text> </View> ); }, }); var styles = StyleSheet.create({ container: { flex: 1, }, };
Configuration menu - View commit details
-
Copy full SHA for 901c24e - Browse repository at this point
Copy the full SHA 901c24eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58a550f - Browse repository at this point
Copy the full SHA 58a550fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f7ebf2 - Browse repository at this point
Copy the full SHA 0f7ebf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4622247 - Browse repository at this point
Copy the full SHA 4622247View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3595b79 - Browse repository at this point
Copy the full SHA 3595b79View commit details -
[react_native] JS files from D2012956: [react_native] Never return nu…
…ll from XHR.getAllResponseHeaders if request has completed
Configuration menu - View commit details
-
Copy full SHA for eafe930 - Browse repository at this point
Copy the full SHA eafe930View commit details -
[ReactNative] Fix Android back btn regression from D2010265
Eric Vicenti committedApr 22, 2015 Configuration menu - View commit details
-
Copy full SHA for 7aa413d - Browse repository at this point
Copy the full SHA 7aa413dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0727cde - Browse repository at this point
Copy the full SHA 0727cdeView commit details -
[react-packager] Additional data to asset modules
Amjad Masad committedApr 22, 2015 Configuration menu - View commit details
-
Copy full SHA for b4c82a4 - Browse repository at this point
Copy the full SHA b4c82a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc6e209 - Browse repository at this point
Copy the full SHA fc6e209View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5ea25f - Browse repository at this point
Copy the full SHA c5ea25fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 459b6a1 - Browse repository at this point
Copy the full SHA 459b6a1View commit details