Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from Wed 22 Apr #976

Closed
wants to merge 63 commits into from
Closed

Commits on Apr 17, 2015

  1. [react-packager] Add asset extensions to file watch glob in the proje…

    …ct root
    Amjad Masad committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    2975f26 View commit details
    Browse the repository at this point in the history
  2. [ReactNative|Easy] Change watchman too-long error message

    Summary:
    @wez Mentioned this in Issue facebook#239 -- right now when watchman takes too long we recommend you run `watchman` from your terminal which actually expects some arguments, so it prints out the following:
    
    ```
    [pcottle:~/Desktop/react-native:changeErrorMessage]$ watchman
    {
        "error": "invalid command (expected an array with some elements!)",
        "cli_validated": true,
        "version": "3.0.0"
    }
    ```
    
    basically this ends up being more confusing since the command we recommend you run errors out, so lets change it to `watchman version` which at least exists cleanly.
    
    I kept the troubleshooting link as https://facebook.github.io/watchman/docs/troubleshooting.html since it sounds like we will update that with the issue people run into in facebook#239
    Closes facebook#825
    Github Author: Peter Cottle <pcottle@fb.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    pcottle committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    691297a View commit details
    Browse the repository at this point in the history
  3. [Errors] Fix Red Box by fixing providesModule parsing

    Summary:
    cc @amasad
    
    An error occurred while trying to display the Red Box since loadSourceMap was not included in the JS
    bundle. This is because node-haste was treating its docblock as a multiline directive which doesn't make sense for `@providesModule`.
    
    In loadSourceMap.js's case, the directive's value was parsed as "loadSourceMap -- disabled flow due to mysterious validation errors --".
    
    There are two fixes: add a newline under the `@providesModule` directive, and change the module ID code to look at only the first token of the directive. I opted for the latter so we avoid this class of bugs entirely and AFAIK it's nonsensical to have multiple `@providesModule` values anyway.
    
    Closes facebook#866
    Github Author: James Ide <ide@jameside.com>
    
    Test Plan:  Run the packager, trigger an error in an app, see the red box now show up again.
    ide committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    0b6dbdb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dbe8e31 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f117483 View commit details
    Browse the repository at this point in the history
  6. 2 Configuration menu
    Copy the full SHA
    aaaa9a9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    65b6d20 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ab1efbd View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2015

  1. Configuration menu
    Copy the full SHA
    f3e7511 View commit details
    Browse the repository at this point in the history
  2. reinstate @flow

    Basil Hosmer committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    17be6ba View commit details
    Browse the repository at this point in the history
  3. [ReactNative] implement transform styles

    Bill Fisher committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    bd5b12c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b9aaac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ead0f2e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2186691 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2015

  1. Configuration menu
    Copy the full SHA
    0b21df4 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2015

  1. Configuration menu
    Copy the full SHA
    0e67e33 View commit details
    Browse the repository at this point in the history
  2. [react_native] JS files from D2001617: [react_native] Add support for…

    … rendering to hardware textures on Android
    astreet committed Apr 20, 2015
    Configuration menu
    Copy the full SHA
    fde476f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb1fa12 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    88b6df9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    915925d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2d5d55d View commit details
    Browse the repository at this point in the history
  7. Fixed reachability

    nicklockwood committed Apr 20, 2015
    Configuration menu
    Copy the full SHA
    bbd5259 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d6afe1b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5e2f90a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5ce9fa4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0e8bc08 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2434512 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a8a1798 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2015

  1. [react-packager] Implement Packager::getAssets

    Amjad Masad committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    82704ad View commit details
    Browse the repository at this point in the history
  2. Adds opaque and underlayColor to WebView.

    Summary:
    Enables overwriting of underlying colors for WebViews. Especially useful if you want to give your WebView a transparent background.
    Closes facebook#767
    Github Author: Lochlan Wansbrough <lochie@live.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    lwansbrough committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    765779a View commit details
    Browse the repository at this point in the history
  3. [react_native] JS files from D2001635: [react_native] Use hardware la…

    …yers during adsmanager Navigator navigation
    astreet committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    b0348ed View commit details
    Browse the repository at this point in the history
  4. Added RCT_DEBUG

    nicklockwood committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    8e15a0d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a0db658 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    25ae548 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ee898c2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2294da7 View commit details
    Browse the repository at this point in the history
  9. [react-packager] Allow json files as modules

    Amjad Masad committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    77d908b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f1351a4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c46c4a0 View commit details
    Browse the repository at this point in the history
  12. [react-packager] Add jpe?g to asset extensions

    Amjad Masad committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    173615a View commit details
    Browse the repository at this point in the history
  13. [SliderIOS] Apply value after minimum/maximumValue in order to ensure…

    … it is properly set
    
    Summary:
    `value` is clamped between min/max and so order of prop application matters - `value` always ended up being set first in my tests, and consequently a value outside of the default range 0-1 would not work. So this applies the value when the min/max are set.
    
    [Gist of broken example](https://gist.github.com/brentvatne/fc637b3e21d012966f3a)
    
    ![screenshot](http://url.brentvatne.ca/SQPC.png)
    ^ the second slider here should have it's cursor in the middle
    
    /cc @tadeuzagallo
    Closes facebook#835
    Github Author: Brent Vatne <brent.vatne@madriska.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    Brent Vatne committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    5fb5148 View commit details
    Browse the repository at this point in the history
  14. [ReactNative] Navigator touch grant bug from D2001635

    Eric Vicenti committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    45c10ff View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c0c2d4c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c6ad7b8 View commit details
    Browse the repository at this point in the history
  17. [ReactNative] Navigator contextual popToRoute and imperitive vs conte…

    …xtual docs
    Eric Vicenti committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    40eeaf5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    32084c9 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    2ee7eba View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2015

  1. Fix AlertIOS Docs

    Summary:
    The curly braces seems to be redundant.
    Closes facebook#811
    Github Author: xcatliu <xcatliu@gmail.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    xcatliu committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    404f7d9 View commit details
    Browse the repository at this point in the history
  2. Fix Typo

    Summary:
    * This PR fixes a typo for the NetInfo docs page
    Closes facebook#937
    Github Author: Mike Wilcox <mwilcox56@gmail.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    mwilc0x committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    17e5b04 View commit details
    Browse the repository at this point in the history
  3. Implement XmlHttpRequestBase#getAllResponseHeaders and getResponseHeader

    Summary:
    Used facebook#382 as inspiration
    but modified to return null instead of undefined as per the spec at
    https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest
    
    This unblocks use of Dropbox.js within a react-native app, as well
    as any other libraries that make use of these methods in XHR usage.
    
    Closes facebook#872
    Closes facebook#892
    Github Author: Josh Zana <joshzana@gmail.com>
    
    Test Plan: Imported from GitHub, without a `Test Plan:` line.
    joshzana committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    368e507 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1a1500 View commit details
    Browse the repository at this point in the history
  5. [Text] Ensure that the text background is transparent by default

    Summary:
    For a very simple view I was observing that the text background was black and had to manually be set to transparent. This ensures that text nodes have a transparent background by default.
    
    Closes facebook#256
    Github Author: James Ide <ide@jameside.com>
    
    Test Plan:
     This example component no longer renders what looks like a black block, and instead displays legible text.
    
        var Example = React.createClass({
          render: function() {
              return (
                <View style={styles.container}>
                  <Text>hello</Text>
                </View>
              );
          },
        });
    
        var styles = StyleSheet.create({
          container: {
            flex: 1,
          },
        };
    ide committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    901c24e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    58a550f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0f7ebf2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4622247 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3595b79 View commit details
    Browse the repository at this point in the history
  10. [react_native] JS files from D2012956: [react_native] Never return nu…

    …ll from XHR.getAllResponseHeaders if request has completed
    astreet committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    eafe930 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7aa413d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0727cde View commit details
    Browse the repository at this point in the history
  13. [react-packager] Additional data to asset modules

    Amjad Masad committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    b4c82a4 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    fc6e209 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c5ea25f View commit details
    Browse the repository at this point in the history
  16. Updates from Wed 22 Apr

    sahrens committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    459b6a1 View commit details
    Browse the repository at this point in the history