Fix polyfill for unitless lineHeight #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compressed-size: runtime library Size change: +0.06 kB
View unchanged
|
When a unitless lineHeight is inherited, it multiples the value of the fontSize of the inheriting element. But when an em value is inherited, it multiples the value of the fontSize of the element it was originally applied to, not the one on the inheriting element.
necolas
force-pushed
the
fix-polyfill-lineheight-unitless
branch
from
934a050 to
85f011c
Compare
mellyeliu
reviewed
Apr 25, 2024
| const lineHeightValue = parseFloat(styleValue); | ||
| // Only convert unitless lineHeight if fontSize exists | ||
| if (style.fontSize != null) { | ||
| if (style.fontSize instanceof CSSLengthUnitValue) { |
There was a problem hiding this comment.
awesome! so now we process the multiplier into a px value based on the current font size?
There was a problem hiding this comment.
We were doing that before too, but earlier in the translation process. Before, it would be converted to px straight away based on whatever the fontSize was on the element that defined lineHeight. After, it will not be converted to px until it is being rendered to an element (e.g., deeper in the tree), which should allow the unitless number to be inherited properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a unitless lineHeight is inherited, it multiples the value of the fontSize of the inheriting element. But when an em value is inherited, it multiples the value of the fontSize of the element it was originally applied to, not the one on the inheriting element.
This patch fixes the resolved values to match web's computed values, but React Native itself renders line-height differently from web, as you can see in these screenshots. Text elements have a semi-transparent red background. React Native changes the shape of the text element box when the line box size changes, and the line box of the parent text seems to grow to match the largest nested line box.
Web
Native