Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html.img event bug in Fabric #72

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix html.img event bug in Fabric #72

merged 1 commit into from
Apr 4, 2024

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 3, 2024

React Native's "Fabric" architecture appears to have a bug and does not populate the Image 'load' event with 'source' data.

Copy link

github-actions bot commented Apr 3, 2024

compressed-size: runtime library

Size change: +0.00 kB
Total size: 18.79 kB

Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/native/index.js 14.83 (46.37) +0.00 (+0.00) 0.0% (0.0%)
View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/dom/index.js 3.00 (9.04) 0.00 (0.00) 0.0% (0.0%)
./packages/react-strict-dom/dist/dom/runtime.js 0.95 (2.33) 0.00 (0.00) 0.0% (0.0%)

React Native's "Fabric" architecture appears to have a bug and does not
populate the Image 'load' event with 'source' data.
@necolas necolas force-pushed the fix-fabric-event-bug branch from 232da27 to 224470a Compare April 3, 2024 21:58
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@necolas
Copy link
Contributor Author

necolas commented Apr 4, 2024

RN issue: facebook/react-native#43874

@necolas necolas merged commit a770fc3 into main Apr 4, 2024
6 checks passed
@necolas necolas deleted the fix-fabric-event-bug branch April 4, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants