Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide structured error/warn messages #86

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 11, 2024

Improve the DX of using LogBox suppression in React Native by using a common structure for error/warn messages. This allows for easier configuration to suppress either specific messages, or categories of messages, e.g., "all unsupported properties" or "all unsupported values".

Copy link

github-actions bot commented Apr 11, 2024

compressed-size: runtime library

Size change: -0.02 kB
Total size: 18.78 kB

Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/dom/index.js 2.99 (8.99) -0.00 (-0.01) -0.1% (-0.1%)
./packages/react-strict-dom/dist/native/index.js 14.84 (46.31) -0.01 (-0.12) -0.1% (-0.3%) 🟢
View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/dom/runtime.js 0.95 (2.33) 0.00 (0.00) 0.0% (0.0%)

Improve the DX of using LogBox suppression in React Native by using a
common structure for error/warn messages. This allows for easier
configuration to suppress either specific messages, or categories of
messages, e.g., "all unsupported properties" or "all unsupported
values".
@necolas necolas force-pushed the structured-warn-error-msg branch from 832ccee to 152cdc4 Compare April 11, 2024 05:54
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the idea of consistent error message strings.

Does it make sense to create additional helper methods on LogBox to enforce one of the patterns?

@necolas necolas merged commit aeed600 into main Apr 11, 2024
6 checks passed
@necolas necolas deleted the structured-warn-error-msg branch April 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants