Dedupe and DEV-only deprecation warning in server renderer

facebook · Jan 17, 2018 · 035c220 · 035c220
1 parent 1047182
commit 035c220
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMServerLifecycles-test.js b/packages/react-dom/src/__tests__/ReactDOMServerLifecycles-test.js
@@ -77,6 +77,9 @@ describe('ReactDOMServerLifecycles', () => {
       'Warning: Component: componentWillMount() is deprecated and will be removed ' +
         'in the next major version. Please use unsafe_componentWillMount() instead.',
     );
+
+    // De-duped
+    ReactDOMServer.renderToString(<Component />);
   });
 
   it('should update instance.state with value returned from getDerivedStateFromProps', () => {

diff --git a/packages/react-dom/src/server/ReactPartialRenderer.js b/packages/react-dom/src/server/ReactPartialRenderer.js
@@ -123,6 +123,7 @@ let didWarnDefaultTextareaValue = false;
 let didWarnInvalidOptionChildren = false;
 const didWarnAboutNoopUpdateForComponent = {};
 const didWarnAboutBadClass = {};
+const didWarnAboutDeprecatedWillMount = {};
 const didWarnAboutUndefinedDerivedState = {};
 const valuePropNames = ['value', 'defaultValue'];
 const newlineEatingTags = {
@@ -487,12 +488,20 @@ function resolve(
     }
     if (inst.unsafe_componentWillMount || inst.componentWillMount) {
       if (inst.componentWillMount) {
-        warning(
-          false,
-          '%s: componentWillMount() is deprecated and will be removed in the ' +
-            'next major version. Please use unsafe_componentWillMount() instead.',
-          getComponentName(Component) || 'Unknown',
-        );
+        if (__DEV__) {
+          const componentName = getComponentName(Component) || 'Unknown';
+
+          if (!didWarnAboutDeprecatedWillMount[componentName]) {
+            warning(
+              false,
+              '%s: componentWillMount() is deprecated and will be removed in the ' +
+                'next major version. Please use unsafe_componentWillMount() instead.',
+              componentName,
+            );
+            didWarnAboutDeprecatedWillMount[componentName] = true;
+          }
+        }
+
         inst.componentWillMount();
       } else {
         inst.unsafe_componentWillMount();