Skip to content

Commit

Permalink
Responding to code review #9221 (review) . Thanks @spicyj!
Browse files Browse the repository at this point in the history
  • Loading branch information
aickin committed Mar 24, 2017
1 parent 091d7fd commit 0d389f8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 23 deletions.
2 changes: 0 additions & 2 deletions scripts/fiber/tests-failing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders no HTML events with client render on top of good server markup
* renders a div with text with client render on top of good server markup
* renders a div with text with flanking whitespace with client render on top of good server markup
* renders a div with text child in brackets with client render on top of good server markup
* renders a div with an empty text child with client render on top of good server markup
* renders a div with multiple empty text children with server string render
* renders a div with multiple empty text children with client render on top of good server markup
Expand Down Expand Up @@ -90,7 +89,6 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a newline-eating tag with content starting with \n with client render on top of good server markup
* renders a normal tag with content starting with \n with client render on top of good server markup
* renders stateless components with client render on top of good server markup
* renders React.createClass components with client render on top of good server markup
* renders ES6 class components with client render on top of good server markup
* renders factory components with client render on top of good server markup
* renders single child hierarchies of components with client render on top of good server markup
Expand Down
2 changes: 0 additions & 2 deletions scripts/fiber/tests-passing-except-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders no HTML events with client render on top of bad server markup
* renders a div with text with client render on top of bad server markup
* renders a div with text with flanking whitespace with client render on top of bad server markup
* renders a div with text child in brackets with client render on top of bad server markup
* renders a div with an empty text child with client render on top of bad server markup
* renders a div with multiple empty text children with client render on top of bad server markup
* renders a div with multiple whitespace children with client render on top of bad server markup
Expand Down Expand Up @@ -80,7 +79,6 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a newline-eating tag with content starting with \n with client render on top of bad server markup
* renders a normal tag with content starting with \n with client render on top of bad server markup
* renders stateless components with client render on top of bad server markup
* renders React.createClass components with client render on top of bad server markup
* renders ES6 class components with client render on top of bad server markup
* renders factory components with client render on top of bad server markup
* renders single child hierarchies of components with client render on top of bad server markup
Expand Down
4 changes: 0 additions & 4 deletions scripts/fiber/tests-passing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1142,8 +1142,6 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a div with text with clean client render
* renders a div with text with flanking whitespace with server string render
* renders a div with text with flanking whitespace with clean client render
* renders a div with text child in brackets with server string render
* renders a div with text child in brackets with clean client render
* renders a div with an empty text child with server string render
* renders a div with an empty text child with clean client render
* renders a div with multiple empty text children with clean client render
Expand Down Expand Up @@ -1193,8 +1191,6 @@ src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a normal tag with content starting with \n with clean client render
* renders stateless components with server string render
* renders stateless components with clean client render
* renders React.createClass components with server string render
* renders React.createClass components with clean client render
* renders ES6 class components with server string render
* renders ES6 class components with clean client render
* renders factory components with server string render
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,6 @@ describe('ReactDOMServerIntegration', () => {
expectNode(e.childNodes[0], TEXT_NODE_TYPE, ' Text ');
});

itRenders('a div with text child in brackets', async render => {
const e = await render(<div>{'Text'}</div>);
expect(e.childNodes.length).toBe(1);
expectNode(e.firstChild, TEXT_NODE_TYPE, 'Text');
});

itRenders('a div with an empty text child', async render => {
const e = await render(<div>{''}</div>);
expect(e.childNodes.length).toBe(0);
Expand Down Expand Up @@ -803,15 +797,6 @@ describe('ReactDOMServerIntegration', () => {
checkFooDiv(await render(<StatelessComponent />));
});

itRenders('React.createClass components', async render => {
const RccComponent = React.createClass({
render: function() {
return <div>foo</div>;
},
});
checkFooDiv(await render(<RccComponent />));
});

itRenders('ES6 class components', async render => {
class ClassComponent extends React.Component {
render() {
Expand Down

0 comments on commit 0d389f8

Please sign in to comment.