Apparently Flow doesn't like variables called event

facebook · Sep 29, 2022 · 2abf7db · 2abf7db
1 parent 436d6a5
commit 2abf7db
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 24 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -671,9 +671,9 @@ function commitUseEventMount(finishedWork: Fiber) {
     // [EventFunctionWrapper, EventFunction, ...], so increment by 2 each iteration to find the next
     // pair.
     for (let ii = 0; ii < eventPayloads.length; ii += 2) {
-      const event: EventFunctionWrapper<any, any, any> = eventPayloads[ii];
+      const eventFn: EventFunctionWrapper<any, any, any> = eventPayloads[ii];
       const nextImpl = eventPayloads[ii + 1];
-      event._impl = nextImpl;
+      eventFn._impl = nextImpl;
     }
   }
 }

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -671,9 +671,9 @@ function commitUseEventMount(finishedWork: Fiber) {
     // [EventFunctionWrapper, EventFunction, ...], so increment by 2 each iteration to find the next
     // pair.
     for (let ii = 0; ii < eventPayloads.length; ii += 2) {
-      const event: EventFunctionWrapper<any, any, any> = eventPayloads[ii];
+      const eventFn: EventFunctionWrapper<any, any, any> = eventPayloads[ii];
       const nextImpl = eventPayloads[ii + 1];
-      event._impl = nextImpl;
+      eventFn._impl = nextImpl;
     }
   }
 }

diff --git a/packages/react-reconciler/src/ReactFiberHooks.new.js b/packages/react-reconciler/src/ReactFiberHooks.new.js
@@ -1898,29 +1898,28 @@ function mountEvent<Args, Return, F: (...Array<Args>) => Return>(
   callback: F,
 ): EventFunctionWrapper<Args, Return, F> {
   const hook = mountWorkInProgressHook();
-
-  const event: EventFunctionWrapper<Args, Return, F> = function event() {
+  const eventFn: EventFunctionWrapper<Args, Return, F> = function eventFn() {
     if (isInvalidExecutionContextForEventFunction()) {
       throw new Error(
         "A function wrapped in useEvent can't be called during rendering.",
       );
     }
-    return event._impl.apply(undefined, arguments);
+    return eventFn._impl.apply(undefined, arguments);
   };
-  event._impl = callback;
+  eventFn._impl = callback;
 
-  useEventImpl(event, callback);
-  hook.memoizedState = event;
-  return event;
+  useEventImpl(eventFn, callback);
+  hook.memoizedState = eventFn;
+  return eventFn;
 }
 
 function updateEvent<Args, Return, F: (...Array<Args>) => Return>(
   callback: F,
 ): EventFunctionWrapper<Args, Return, F> {
   const hook = updateWorkInProgressHook();
-  const event = hook.memoizedState;
-  useEventImpl(event, callback);
-  return event;
+  const eventFn = hook.memoizedState;
+  useEventImpl(eventFn, callback);
+  return eventFn;
 }
 
 function mountInsertionEffect(

diff --git a/packages/react-reconciler/src/ReactFiberHooks.old.js b/packages/react-reconciler/src/ReactFiberHooks.old.js
@@ -1898,29 +1898,28 @@ function mountEvent<Args, Return, F: (...Array<Args>) => Return>(
   callback: F,
 ): EventFunctionWrapper<Args, Return, F> {
   const hook = mountWorkInProgressHook();
-
-  const event: EventFunctionWrapper<Args, Return, F> = function event() {
+  const eventFn: EventFunctionWrapper<Args, Return, F> = function eventFn() {
     if (isInvalidExecutionContextForEventFunction()) {
       throw new Error(
         "A function wrapped in useEvent can't be called during rendering.",
       );
     }
-    return event._impl.apply(undefined, arguments);
+    return eventFn._impl.apply(undefined, arguments);
   };
-  event._impl = callback;
+  eventFn._impl = callback;
 
-  useEventImpl(event, callback);
-  hook.memoizedState = event;
-  return event;
+  useEventImpl(eventFn, callback);
+  hook.memoizedState = eventFn;
+  return eventFn;
 }
 
 function updateEvent<Args, Return, F: (...Array<Args>) => Return>(
   callback: F,
 ): EventFunctionWrapper<Args, Return, F> {
   const hook = updateWorkInProgressHook();
-  const event = hook.memoizedState;
-  useEventImpl(event, callback);
-  return event;
+  const eventFn = hook.memoizedState;
+  useEventImpl(eventFn, callback);
+  return eventFn;
 }
 
 function mountInsertionEffect(