Skip to content

Commit

Permalink
Remove redundant props assign (#28829)
Browse files Browse the repository at this point in the history
DiffTrain build for [9defcd5](9defcd5)
  • Loading branch information
kassens committed Apr 15, 2024
1 parent 5f5d13f commit 34d4293
Show file tree
Hide file tree
Showing 17 changed files with 49 additions and 49 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ed4023603632787db6416bee8e85e68d98ad29bd
9defcd56bc3cd53ac2901ed93f29218007010434
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "19.0.0-www-classic-1d4ea768";
var ReactVersion = "19.0.0-www-classic-e168c427";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -14302,7 +14302,7 @@ if (__DEV__) {
// We may have already copied the props object above to remove ref. If so,
// we can modify that. Otherwise, copy the props object with Object.assign.
if (newProps === baseProps) {
newProps = assign({}, newProps, baseProps);
newProps = assign({}, newProps);
} // Taken from old JSX runtime, where this used to live.

for (var _propName in defaultProps) {
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "19.0.0-www-modern-ecaff604";
var ReactVersion = "19.0.0-www-modern-604f1bb4";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -14012,7 +14012,7 @@ if (__DEV__) {
// We may have already copied the props object above to remove ref. If so,
// we can modify that. Otherwise, copy the props object with Object.assign.
if (newProps === baseProps) {
newProps = assign({}, newProps, baseProps);
newProps = assign({}, newProps);
} // Taken from old JSX runtime, where this used to live.

for (var _propName in defaultProps) {
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3937,7 +3937,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$36 in Component)
void 0 === newProps[propName$36] &&
(newProps[propName$36] = Component[propName$36]);
Expand Down Expand Up @@ -10619,7 +10619,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "19.0.0-www-classic-ce4ebc75",
version: "19.0.0-www-classic-e5fcf28b",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1322 = {
Expand Down Expand Up @@ -10650,7 +10650,7 @@ var internals$jscomp$inline_1322 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-ce4ebc75"
reconcilerVersion: "19.0.0-www-classic-e5fcf28b"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1323 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3673,7 +3673,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$36 in Component)
void 0 === newProps[propName$36] &&
(newProps[propName$36] = Component[propName$36]);
Expand Down Expand Up @@ -10098,7 +10098,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "19.0.0-www-modern-3bbc0838",
version: "19.0.0-www-modern-20a4f736",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1307 = {
Expand Down Expand Up @@ -10129,7 +10129,7 @@ var internals$jscomp$inline_1307 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-3bbc0838"
reconcilerVersion: "19.0.0-www-modern-20a4f736"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1308 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19083,7 +19083,7 @@ if (__DEV__) {
// We may have already copied the props object above to remove ref. If so,
// we can modify that. Otherwise, copy the props object with Object.assign.
if (newProps === baseProps) {
newProps = assign({}, newProps, baseProps);
newProps = assign({}, newProps);
} // Taken from old JSX runtime, where this used to live.

for (var _propName in defaultProps) {
Expand Down Expand Up @@ -36250,7 +36250,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "19.0.0-www-classic-45bbbf3f";
var ReactVersion = "19.0.0-www-classic-ccb6967b";

function createPortal$1(
children,
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -32161,7 +32161,7 @@ if (__DEV__) {
// We may have already copied the props object above to remove ref. If so,
// we can modify that. Otherwise, copy the props object with Object.assign.
if (newProps === baseProps) {
newProps = assign({}, newProps, baseProps);
newProps = assign({}, newProps);
} // Taken from old JSX runtime, where this used to live.

for (var _propName in defaultProps) {
Expand Down Expand Up @@ -45766,7 +45766,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "19.0.0-www-modern-ffeb51f8";
var ReactVersion = "19.0.0-www-modern-f3e31fa4";

function createPortal$1(
children,
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4788,7 +4788,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$63 in Component)
void 0 === newProps[propName$63] &&
(newProps[propName$63] = Component[propName$63]);
Expand Down Expand Up @@ -17033,7 +17033,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1729 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-2ccb4542",
version: "19.0.0-www-classic-38c43cf6",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2160 = {
Expand Down Expand Up @@ -17063,7 +17063,7 @@ var internals$jscomp$inline_2160 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-2ccb4542"
reconcilerVersion: "19.0.0-www-classic-38c43cf6"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2161 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17529,4 +17529,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-2ccb4542";
exports.version = "19.0.0-www-classic-38c43cf6";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9904,7 +9904,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$174 in Component)
void 0 === newProps[propName$174] &&
(newProps[propName$174] = Component[propName$174]);
Expand Down Expand Up @@ -16395,7 +16395,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1722 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-modern-1ef16194",
version: "19.0.0-www-modern-1217c10a",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2162 = {
Expand Down Expand Up @@ -16425,7 +16425,7 @@ var internals$jscomp$inline_2162 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-1ef16194"
reconcilerVersion: "19.0.0-www-modern-1217c10a"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2163 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16733,4 +16733,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-1ef16194";
exports.version = "19.0.0-www-modern-1217c10a";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4996,7 +4996,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$68 in Component)
void 0 === newProps[propName$68] &&
(newProps[propName$68] = Component[propName$68]);
Expand Down Expand Up @@ -17781,7 +17781,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1815 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-2c470496",
version: "19.0.0-www-classic-a7d2fb9b",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -17825,7 +17825,7 @@ var devToolsConfig$jscomp$inline_1815 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-2c470496"
reconcilerVersion: "19.0.0-www-classic-a7d2fb9b"
});
var ReactFiberErrorDialogWWW = require("ReactFiberErrorDialog");
if ("function" !== typeof ReactFiberErrorDialogWWW.showErrorDialog)
Expand Down Expand Up @@ -18278,7 +18278,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-2c470496";
exports.version = "19.0.0-www-classic-a7d2fb9b";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10135,7 +10135,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$180 in Component)
void 0 === newProps[propName$180] &&
(newProps[propName$180] = Component[propName$180]);
Expand Down Expand Up @@ -17126,7 +17126,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1808 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-modern-98727eae",
version: "19.0.0-www-modern-1e359311",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -17170,7 +17170,7 @@ var devToolsConfig$jscomp$inline_1808 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-98727eae"
reconcilerVersion: "19.0.0-www-modern-1e359311"
});
var ReactFiberErrorDialogWWW = require("ReactFiberErrorDialog");
if ("function" !== typeof ReactFiberErrorDialogWWW.showErrorDialog)
Expand Down Expand Up @@ -17465,7 +17465,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-98727eae";
exports.version = "19.0.0-www-modern-1e359311";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19212,7 +19212,7 @@ if (__DEV__) {
// We may have already copied the props object above to remove ref. If so,
// we can modify that. Otherwise, copy the props object with Object.assign.
if (newProps === baseProps) {
newProps = assign({}, newProps, baseProps);
newProps = assign({}, newProps);
} // Taken from old JSX runtime, where this used to live.

for (var _propName in defaultProps) {
Expand Down Expand Up @@ -36866,7 +36866,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "19.0.0-www-classic-47100ad2";
var ReactVersion = "19.0.0-www-classic-c52cc1c4";

function createPortal$1(
children,
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -32290,7 +32290,7 @@ if (__DEV__) {
// We may have already copied the props object above to remove ref. If so,
// we can modify that. Otherwise, copy the props object with Object.assign.
if (newProps === baseProps) {
newProps = assign({}, newProps, baseProps);
newProps = assign({}, newProps);
} // Taken from old JSX runtime, where this used to live.

for (var _propName in defaultProps) {
Expand Down Expand Up @@ -46514,7 +46514,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "19.0.0-www-modern-b6b5a18a";
var ReactVersion = "19.0.0-www-modern-8a063592";

function createPortal$1(
children,
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4874,7 +4874,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$63 in Component)
void 0 === newProps[propName$63] &&
(newProps[propName$63] = Component[propName$63]);
Expand Down Expand Up @@ -12843,7 +12843,7 @@ function injectIntoDevTools(devToolsConfig) {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-acb7e6d0"
reconcilerVersion: "19.0.0-www-classic-8729eb10"
};
if ("undefined" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__)
devToolsConfig = !1;
Expand Down Expand Up @@ -17406,7 +17406,7 @@ Internals.Events = [
injectIntoDevTools({
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-acb7e6d0",
version: "19.0.0-www-classic-8729eb10",
rendererPackageName: "react-dom"
});
var ReactFiberErrorDialogWWW = require("ReactFiberErrorDialog");
Expand Down Expand Up @@ -17539,7 +17539,7 @@ assign(Internals, {
injectIntoDevTools({
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-acb7e6d0",
version: "19.0.0-www-classic-8729eb10",
rendererPackageName: "react-dom"
});
exports.__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE =
Expand Down Expand Up @@ -18006,4 +18006,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-acb7e6d0";
exports.version = "19.0.0-www-classic-8729eb10";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10049,7 +10049,7 @@ function resolveClassComponentProps(
(Component = Component.defaultProps) &&
(disableDefaultPropsExceptForClasses || !alreadyResolvedDefaultProps)
) {
newProps === baseProps && (newProps = assign({}, newProps, baseProps));
newProps === baseProps && (newProps = assign({}, newProps));
for (var propName$174 in Component)
void 0 === newProps[propName$174] &&
(newProps[propName$174] = Component[propName$174]);
Expand Down Expand Up @@ -16129,7 +16129,7 @@ function injectIntoDevTools(devToolsConfig) {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-5250b372"
reconcilerVersion: "19.0.0-www-modern-375fcad7"
};
if ("undefined" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__)
devToolsConfig = !1;
Expand Down Expand Up @@ -16827,15 +16827,15 @@ Internals.Events = [
injectIntoDevTools({
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-modern-5250b372",
version: "19.0.0-www-modern-375fcad7",
rendererPackageName: "react-dom"
});
if ("function" !== typeof require("ReactFiberErrorDialog").showErrorDialog)
throw Error(formatProdErrorMessage(320));
injectIntoDevTools({
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-modern-5250b372",
version: "19.0.0-www-modern-375fcad7",
rendererPackageName: "react-dom"
});
exports.__DOM_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE =
Expand Down Expand Up @@ -17249,4 +17249,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-5250b372";
exports.version = "19.0.0-www-modern-375fcad7";
Loading

0 comments on commit 34d4293

Please sign in to comment.