Merge pull request #3665 from mridgway/replaceHasOwnProperty

[performance] Replace hasOwnProperty in child processing with typeof undefined check
facebook · Apr 22, 2015 · 3c66b8f · 3c66b8f
2 parents d235940 + ed70d35
commit 3c66b8f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/utils/ReactChildren.js b/src/utils/ReactChildren.js
@@ -81,7 +81,7 @@ function mapSingleChildIntoContext(traverseContext, child, name, i) {
   var mapBookKeeping = traverseContext;
   var mapResult = mapBookKeeping.mapResult;
 
-  var keyUnique = !mapResult.hasOwnProperty(name);
+  var keyUnique = (mapResult[name] === undefined);
   if (__DEV__) {
     warning(
       keyUnique,

diff --git a/src/utils/flattenChildren.js b/src/utils/flattenChildren.js
@@ -22,7 +22,7 @@ var warning = require('warning');
 function flattenSingleChildIntoContext(traverseContext, child, name) {
   // We found a component instance.
   var result = traverseContext;
-  var keyUnique = !result.hasOwnProperty(name);
+  var keyUnique = (result[name] === undefined);
   if (__DEV__) {
     warning(
       keyUnique,