Skip to content

Commit

Permalink
Fix - issue #12765 / the checked attribute is not initially set on th…
Browse files Browse the repository at this point in the history
…e input
  • Loading branch information
Wensheng Xu committed Jun 28, 2018
1 parent 6d6de60 commit 3e8ca2f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMInput-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -739,9 +739,12 @@ describe('ReactDOMInput', () => {
const cNode = stub.refs.c;

expect(aNode.checked).toBe(true);
expect(aNode.getAttribute('checked')).toBe('');
expect(bNode.checked).toBe(false);
expect(bNode.getAttribute('checked')).toBe(null);
// c is in a separate form and shouldn't be affected at all here
expect(cNode.checked).toBe(true);
expect(cNode.getAttribute('checked')).toBe('');

bNode.checked = true;
// This next line isn't necessary in a proper browser environment, but
Expand All @@ -750,6 +753,11 @@ describe('ReactDOMInput', () => {
aNode.checked = false;
expect(cNode.checked).toBe(true);

// The original 'checked' attribute should be unchanged
expect(aNode.getAttribute('checked')).toBe('');
expect(bNode.getAttribute('checked')).toBe(null);
expect(cNode.getAttribute('checked')).toBe('');

// Now let's run the actual ReactDOMInput change event handler
ReactTestUtils.Simulate.change(bNode);

Expand Down
2 changes: 1 addition & 1 deletion packages/react-dom/src/client/ReactDOMFiberInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export function postMountWrapper(
if (name !== '') {
node.name = '';
}
node.defaultChecked = !node.defaultChecked;
node.defaultChecked = !node._wrapperState.initialChecked;
node.defaultChecked = !node.defaultChecked;
if (name !== '') {
node.name = name;
Expand Down

0 comments on commit 3e8ca2f

Please sign in to comment.