Rename startWriting to pipe

This mirrors the ReadableStream API in Node
facebook · Oct 6, 2021 · 404e036 · 404e036
1 parent 21db19f
commit 404e036
Show file tree

Hide file tree

Showing 8 changed files with 106 additions and 114 deletions.
diff --git a/fixtures/flight/server/handler.server.js b/fixtures/flight/server/handler.server.js
@@ -20,11 +20,8 @@ module.exports = function(req, res) {
         const App = m.default.default || m.default;
         res.setHeader('Access-Control-Allow-Origin', '*');
         const moduleMap = JSON.parse(data);
-        const {startWriting} = renderToNodePipe(
-          React.createElement(App),
-          moduleMap
-        );
-        startWriting(res);
+        const {pipe} = renderToNodePipe(React.createElement(App), moduleMap);
+        pipe(res);
       }
     );
   });

diff --git a/fixtures/ssr/server/render.js b/fixtures/ssr/server/render.js
@@ -20,12 +20,12 @@ export default function render(url, res) {
     console.error('Fatal', error);
   });
   let didError = false;
-  const {startWriting, abort} = renderToNodePipe(<App assets={assets} />, {
+  const {pipe, abort} = renderToNodePipe(<App assets={assets} />, {
     onCompleteShell() {
       // If something errored before we started streaming, we set the error code appropriately.
       res.statusCode = didError ? 500 : 200;
       res.setHeader('Content-type', 'text/html');
-      startWriting(res);
+      pipe(res);
     },
     onError(x) {
       didError = true;

diff --git a/fixtures/ssr2/server/render.js b/fixtures/ssr2/server/render.js
@@ -37,7 +37,7 @@ module.exports = function render(url, res) {
   });
   let didError = false;
   const data = createServerData();
-  const {startWriting, abort} = renderToNodePipe(
+  const {pipe, abort} = renderToNodePipe(
     <DataProvider data={data}>
       <App assets={assets} />
     </DataProvider>,
@@ -46,7 +46,7 @@ module.exports = function render(url, res) {
         // If something errored before we started streaming, we set the error code appropriately.
         res.statusCode = didError ? 500 : 200;
         res.setHeader('Content-type', 'text/html');
-        startWriting(res);
+        pipe(res);
       },
       onError(x) {
         didError = true;