Inline the Number.isNaN polyfill

facebook · Jan 12, 2016 · 59d5d01 · 59d5d01
1 parent c82ce1d
commit 59d5d01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/src/renderers/dom/shared/CSSPropertyOperations.js b/src/renderers/dom/shared/CSSPropertyOperations.js
@@ -20,7 +20,6 @@ var dangerousStyleValue = require('dangerousStyleValue');
 var hyphenateStyleName = require('hyphenateStyleName');
 var memoizeStringOnly = require('memoizeStringOnly');
 var warning = require('warning');
-var numberIsNaN = require('../../../shared/stubs/Number.isNaN');
 
 var processStyleName = memoizeStringOnly(function(styleName) {
   return hyphenateStyleName(styleName);
@@ -51,6 +50,7 @@ if (__DEV__) {
 
   var warnedStyleNames = {};
   var warnedStyleValues = {};
+  var warnedForNaNValue = false;
 
   var warnHyphenatedStyleName = function(name) {
     if (warnedStyleNames.hasOwnProperty(name) && warnedStyleNames[name]) {
@@ -96,11 +96,11 @@ if (__DEV__) {
   };
 
   var warnStyleValueIsNaN = function(name, value) {
-    if (warnedStyleValues.hasOwnProperty(value) && warnedStyleValues[value]) {
+    if (warnedForNaNValue) {
       return;
     }
 
-    warnedStyleValues[value] = true;
+    warnedForNaNValue = true;
     warning(
       false,
       '`NaN` is an invalid value for the `%s` css style property',
@@ -121,7 +121,7 @@ if (__DEV__) {
       warnStyleValueWithSemicolon(name, value);
     }
 
-    if (numberIsNaN(value)) {
+    if (typeof value === 'number' && isNaN(value)) {
       warnStyleValueIsNaN(name, value);
     }
   };

diff --git a/src/shared/stubs/Number.isNaN.js b/src/shared/stubs/Number.isNaN.js