feat(createContext): Include displayName in warning (#18386)

facebook · Apr 1, 2020 · 7516bdf · 7516bdf
1 parent 9b88b78
commit 7516bdf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/react/src/ReactContext.js b/packages/react/src/ReactContext.js
@@ -125,11 +125,12 @@ export function createContext<T>(
         get() {
           return context.displayName;
         },
-        set() {
+        set(displayName) {
           if (!hasWarnedAboutDisplayNameOnConsumer) {
             console.warn(
               'Setting `displayName` on Context.Consumer has no effect. ' +
-                "You should set it directly on the context with Context.displayName = 'NamedContext'.",
+                "You should set it directly on the context with Context.displayName = '%s'.",
+              displayName,
             );
             hasWarnedAboutDisplayNameOnConsumer = true;
           }

diff --git a/packages/react/src/__tests__/ReactContextValidator-test.js b/packages/react/src/__tests__/ReactContextValidator-test.js
@@ -700,14 +700,14 @@ describe('ReactContextValidator', () => {
     const Context = React.createContext(null);
 
     expect(() => {
-      Context.Consumer.displayName = 'ignored';
+      Context.Consumer.displayName = 'IgnoredName';
     }).toWarnDev(
       'Warning: Setting `displayName` on Context.Consumer has no effect. ' +
-        "You should set it directly on the context with Context.displayName = 'NamedContext'.",
+        "You should set it directly on the context with Context.displayName = 'IgnoredName'.",
       {withoutStack: true},
     );
 
-    // warning is deduped so subsequent setting is fine
-    Context.Consumer.displayName = 'ignored';
+    // warning is deduped by Context so subsequent setting is fine
+    Context.Consumer.displayName = 'ADifferentName';
   });
 });