-
Notifications
You must be signed in to change notification settings - Fork 46.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: Coerce form submitter action prop
When handling form action functions, we should coerce the submitter formAction prop using the same logic as ReactDOMComponent before deciding whether it should override the action on the <form>. Before this fix, if the submitter's `formAction` prop was a symbol or a boolean, it would block the form's action function from firing, but the correct behavior is that symbols and booleans should be treated as if they were null/empty, because that's how we treat those values when setting DOM properties.
- Loading branch information
Showing
2 changed files
with
78 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters