Check each renderer's config with Flow

facebook · May 18, 2018 · 7c55e9e · 7c55e9e
1 parent d292923
commit 7c55e9e
Show file tree

Hide file tree

Showing 56 changed files with 1,044 additions and 983 deletions.
diff --git a/packages/react-art/src/ReactART.js b/packages/react-art/src/ReactART.js
@@ -6,7 +6,7 @@
  */
 
 import React from 'react';
-import * as ARTRenderer from 'react-reconciler/inline';
+import * as ARTRenderer from 'react-reconciler/inline.art';
 import Transform from 'art/core/transform';
 import Mode from 'art/modes/current';
 import FastNoSideEffects from 'art/modes/fast-noSideEffects';

diff --git a/packages/react-art/src/ReactARTHostConfig.js b/packages/react-art/src/ReactARTHostConfig.js
@@ -234,6 +234,9 @@ function applyTextProps(instance, props, prevProps = {}) {
   }
 }
 
+export * from 'shared/HostConfigWithNoPersistence';
+export * from 'shared/HostConfigWithNoHydration';
+
   export function appendInitialChild(parentInstance, child) {
     if (typeof child === 'string') {
       // Noop for string children of Text (eg <Text>{'foo'}{'bar'}</Text>)
@@ -333,8 +336,6 @@ function applyTextProps(instance, props, prevProps = {}) {
   export const isPrimaryRenderer = false;
 
   export const supportsMutation = true;
-  export const supportsPersistence = false;
-  export const supportsHydration = false;
 
     export function appendChild(parentInstance, child) {
       if (child.parentNode === parentInstance) {
@@ -388,80 +389,3 @@ function applyTextProps(instance, props, prevProps = {}) {
       instance._applyProps(instance, newProps, oldProps);
     }
 
-
-export function cloneInstance() {
-  // not supported
-}
-
-export function createContainerChildSet() {
-  // not supported
-}
-
-export function appendChildToContainerChildSet() {
-  // not supported
-}
-
-export function finalizeContainerChildren() {
-  // not supported
-}
-
-export function replaceContainerChildren() {
-  // not supported
-}
-
-
-export function canHydrateInstance() {
-  // not supported
-}
-
-export function canHydrateTextInstance() {
-  // not supported
-}
-
-export function getNextHydratableSibling() {
-  // not supported
-}
-
-export function getFirstHydratableChild() {
-  // not supported
-}
-
-export function hydrateInstance() {
-  // not supported
-}
-
-export function hydrateTextInstance() {
-  // not supported
-}
-
-export function didNotMatchHydratedContainerTextInstance() {
-  // not supported
-}
-
-export function didNotMatchHydratedTextInstance() {
-  // not supported
-}
-
-export function didNotHydrateContainerInstance() {
-  // not supported
-}
-
-export function didNotHydrateInstance() {
-  // not supported
-}
-
-export function didNotFindHydratableContainerInstance() {
-  // not supported
-}
-
-export function didNotFindHydratableContainerTextInstance() {
-  // not supported
-}
-
-export function didNotFindHydratableInstance() {
-  // not supported
-}
-
-export function didNotFindHydratableTextInstance() {
-  // not supported
-}
diff --git a/packages/react-dom/src/client/ReactDOM.js b/packages/react-dom/src/client/ReactDOM.js
@@ -19,7 +19,7 @@ import type {Container} from './ReactDOMHostConfig';
 import '../shared/checkReact';
 import './ReactDOMClientInjection';
 
-import * as DOMRenderer from 'react-reconciler/inline';
+import * as DOMRenderer from 'react-reconciler/inline.dom';
 import * as ReactPortal from 'shared/ReactPortal';
 import ExecutionEnvironment from 'fbjs/lib/ExecutionEnvironment';
 import * as ReactGenericBatching from 'events/ReactGenericBatching';

diff --git a/packages/react-dom/src/client/ReactDOMHostConfig.js b/packages/react-dom/src/client/ReactDOMHostConfig.js
@@ -24,6 +24,19 @@ import {
   DOCUMENT_FRAGMENT_NODE,
 } from '../shared/HTMLNodeType';
 
+
+export type T = string;
+export type P = Object;
+export type I = Element;
+export type TI = Text;
+export type HI = Element | Text;
+export type PI = Element | Text;
+export type C = Element | Document;
+export type CC = void;
+export type CX = string | { namespace: string, ancestorInfo: mixed };
+export type PL = Array<mixed>;
+
+
 export type Container = Element | Document;
 type Props = {
   autoFocus?: boolean,
@@ -77,6 +90,10 @@ function shouldAutoFocusHostComponent(type: string, props: Props): boolean {
   return false;
 }
 
+
+export * from 'shared/HostConfigWithNoPersistence';
+
+
 export function getRootHostContext(rootContainerInstance: Container): HostContext {
     let type;
     let namespace;
@@ -111,6 +128,7 @@ export function getRootHostContext(rootContainerInstance: Container): HostContex
 export function getChildHostContext(
     parentHostContext: HostContext,
     type: string,
+    instance: *
   ): HostContext {
     if (__DEV__) {
       const parentHostContextDev = ((parentHostContext: any): HostContextDev);
@@ -130,13 +148,13 @@ export function  getPublicInstance(instance: Instance | TextInstance): * {
     return instance;
   }
 
-export function  prepareForCommit(): void {
+export function  prepareForCommit(containerInfo: *): void {
     eventsEnabled = ReactBrowserEventEmitter.isEnabled();
     selectionInformation = ReactInputSelection.getSelectionInformation();
     ReactBrowserEventEmitter.setEnabled(false);
   }
 
-export function resetAfterCommit(): void {
+export function resetAfterCommit(containerInfo: *): void {
     ReactInputSelection.restoreSelection(selectionInformation);
     selectionInformation = null;
     ReactBrowserEventEmitter.setEnabled(eventsEnabled);
@@ -194,6 +212,7 @@ export function finalizeInitialChildren(
     type: string,
     props: Props,
     rootContainerInstance: Container,
+    hostContext: *,
   ): boolean {
     setInitialProperties(domElement, type, props, rootContainerInstance);
     return shouldAutoFocusHostComponent(type, props);
@@ -267,7 +286,6 @@ export function prepareUpdate(
   export const isPrimaryRenderer = true;
 
   export const supportsMutation = true;
-  export const supportsPersistence = false;
   export const supportsHydration = true;
 
   export function commitMount(
@@ -565,24 +583,3 @@ export function prepareUpdate(
   export const scheduleDeferredCallback = ReactScheduler.scheduleWork;
   export const cancelDeferredCallback = ReactScheduler.cancelScheduledWork;
 
-
-export function cloneInstance() {
-  // not supported
-}
-
-export function createContainerChildSet() {
-  // not supported
-}
-
-export function appendChildToContainerChildSet() {
-  // not supported
-}
-
-export function finalizeContainerChildren() {
-  // not supported
-}
-
-export function replaceContainerChildren() {
-  // not supported
-}
-
diff --git a/packages/react-native-renderer/src/ReactFabric.js b/packages/react-native-renderer/src/ReactFabric.js
@@ -12,7 +12,7 @@ import type {ReactNodeList} from 'shared/ReactTypes';
 
 import './ReactFabricInjection';
 
-import * as ReactFabricRenderer from 'react-reconciler/inline';
+import * as ReactFabricRenderer from 'react-reconciler/inline.fabric';
 
 import * as ReactPortal from 'shared/ReactPortal';
 import * as ReactGenericBatching from 'events/ReactGenericBatching';
@@ -65,7 +65,7 @@ function findNodeHandle(componentOrHandle: any): ?number {
   }
   if (hostInstance.canonical) {
     // Fabric
-    return hostInstance.canonical._nativeTag;
+    return (hostInstance.canonical: any)._nativeTag;
   }
   return hostInstance._nativeTag;
 }