Remove ReactNativePropRegistry (#12559)

This has always been an unnecessary indirection to protect opaqueness,
which hasn't really worked out.

packages/react-native-renderer/src/ReactFabric.js

@@ -21,7 +21,6 @@ import ReactNativeBridgeEventPlugin from './ReactNativeBridgeEventPlugin';
 import ReactNativeComponent from './ReactNativeComponent';
 import * as ReactNativeComponentTree from './ReactNativeComponentTree';
 import ReactFabricRenderer from './ReactFabricRenderer';
-import ReactNativePropRegistry from './ReactNativePropRegistry';
 import {getInspectorDataForViewTag} from './ReactNativeFiberInspector';
 import createReactNativeComponentClass from './createReactNativeComponentClass';
 import {injectFindHostInstance} from './findNodeHandle';
@@ -82,7 +81,6 @@ const ReactFabric: ReactNativeType = {
     // Used by react-native-github/Libraries/ components
     ReactNativeBridgeEventPlugin, // requireNativeComponent
     ReactNativeComponentTree, // ScrollResponder
-    ReactNativePropRegistry, // flattenStyle, Stylesheet
     createReactNativeComponentClass, // RCTText, RCTView, ReactNativeART
   },
 };

packages/react-native-renderer/src/ReactNativeAttributePayload.js

@@ -11,8 +11,6 @@
 import deepDiffer from 'deepDiffer';
 import flattenStyle from 'flattenStyle';
 
-import ReactNativePropRegistry from './ReactNativePropRegistry';
-
 const emptyObject = {};
 
 /**
@@ -38,7 +36,7 @@ type AttributeConfiguration = {
     | AttributeConfiguration /*| boolean*/,
 };
 
-type NestedNode = Array<NestedNode> | Object | number;
+type NestedNode = Array<NestedNode> | Object;
 
 // Tracks removed keys
 let removedKeys = null;
@@ -54,13 +52,6 @@ function defaultDiffer(prevProp: mixed, nextProp: mixed): boolean {
   }
 }
 
-function resolveObject(idOrObject: number | Object): Object {
-  if (typeof idOrObject === 'number') {
-    return ReactNativePropRegistry.getByID(idOrObject);
-  }
-  return idOrObject;
-}
-
 function restoreDeletedValuesInNestedArray(
   updatePayload: Object,
   node: NestedNode,
@@ -76,7 +67,7 @@ function restoreDeletedValuesInNestedArray(
       );
     }
   } else if (node && removedKeyCount > 0) {
-    const obj = resolveObject(node);
+    const obj = node;
     for (const propKey in removedKeys) {
       if (!removedKeys[propKey]) {
         continue;
@@ -180,12 +171,7 @@ function diffNestedProperty(
 
   if (!Array.isArray(prevProp) && !Array.isArray(nextProp)) {
     // Both are leaves, we can diff the leaves.
-    return diffProperties(
-      updatePayload,
-      resolveObject(prevProp),
-      resolveObject(nextProp),
-      validAttributes,
-    );
+    return diffProperties(updatePayload, prevProp, nextProp, validAttributes);
   }
 
   if (Array.isArray(prevProp) && Array.isArray(nextProp)) {
@@ -204,14 +190,14 @@ function diffNestedProperty(
       // $FlowFixMe - We know that this is always an object when the input is.
       flattenStyle(prevProp),
       // $FlowFixMe - We know that this isn't an array because of above flow.
-      resolveObject(nextProp),
+      nextProp,
       validAttributes,
     );
   }
 
   return diffProperties(
     updatePayload,
-    resolveObject(prevProp),
+    prevProp,
     // $FlowFixMe - We know that this is always an object when the input is.
     flattenStyle(nextProp),
     validAttributes,
@@ -234,11 +220,7 @@ function addNestedProperty(
 
   if (!Array.isArray(nextProp)) {
     // Add each property of the leaf.
-    return addProperties(
-      updatePayload,
-      resolveObject(nextProp),
-      validAttributes,
-    );
+    return addProperties(updatePayload, nextProp, validAttributes);
   }
 
   for (let i = 0; i < nextProp.length; i++) {
@@ -268,11 +250,7 @@ function clearNestedProperty(
 
   if (!Array.isArray(prevProp)) {
     // Add each property of the leaf.
-    return clearProperties(
-      updatePayload,
-      resolveObject(prevProp),
-      validAttributes,
-    );
+    return clearProperties(updatePayload, prevProp, validAttributes);
   }
 
   for (let i = 0; i < prevProp.length; i++) {

packages/react-native-renderer/src/ReactNativeRenderer.js

@@ -25,7 +25,6 @@ import ReactNativeBridgeEventPlugin from './ReactNativeBridgeEventPlugin';
 import ReactNativeComponent from './ReactNativeComponent';
 import * as ReactNativeComponentTree from './ReactNativeComponentTree';
 import ReactNativeFiberRenderer from './ReactNativeFiberRenderer';
-import ReactNativePropRegistry from './ReactNativePropRegistry';
 import {getInspectorDataForViewTag} from './ReactNativeFiberInspector';
 import createReactNativeComponentClass from './createReactNativeComponentClass';
 import {injectFindHostInstance} from './findNodeHandle';
@@ -101,7 +100,6 @@ const ReactNativeRenderer: ReactNativeType = {
     // Used by react-native-github/Libraries/ components
     ReactNativeBridgeEventPlugin, // requireNativeComponent
     ReactNativeComponentTree, // ScrollResponder
-    ReactNativePropRegistry, // flattenStyle, Stylesheet
     createReactNativeComponentClass, // RCTText, RCTView, ReactNativeART
     computeComponentStackForErrorReporting,
   },

packages/react-native-renderer/src/ReactNativeTypes.js

@@ -81,7 +81,6 @@ type SecretInternalsType = {
   ): any,
   ReactNativeBridgeEventPlugin: ReactNativeBridgeEventPlugin,
   ReactNativeComponentTree: any,
-  ReactNativePropRegistry: any,
   // TODO (bvaughn) Decide which additional types to expose here?
   // And how much information to fill in for the above types.
 };

packages/react-native-renderer/src/__tests__/ReactNativeAttributePayload-test.js

@@ -9,7 +9,6 @@
 'use strict';
 
 const ReactNativeAttributePayload = require('../ReactNativeAttributePayload');
-const ReactNativePropRegistry = require('../ReactNativePropRegistry').default;
 
 const diff = ReactNativeAttributePayload.diff;
 
@@ -114,9 +113,9 @@ describe('ReactNativeAttributePayload', () => {
       diff({someStyle: [{foo: 1}, {bar: 2}]}, {}, validStyleAttribute),
     ).toEqual({foo: null, bar: null});
 
-    const barStyle = ReactNativePropRegistry.register({
+    const barStyle = {
       bar: 3,
-    });
+    };
 
     expect(
       diff(