Improve error message for components in bad states (missing instance)

facebook · Jun 7, 2016 · 95fd9b3 · 95fd9b3
1 parent ccd26ee
commit 95fd9b3
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js b/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js
@@ -509,6 +509,12 @@ var ReactCompositeComponentMixin = {
       return;
     }
     var inst = this._instance;
+    invariant(
+      inst != null,
+      'Attempted to unmount component `%s` that has already been unmounted ' +
+      '(or failed to mount).',
+      this.getName() || 'ReactCompositeComponent'
+    );
 
     if (inst.componentWillUnmount && !inst._calledComponentWillUnmount) {
       inst._calledComponentWillUnmount = true;
@@ -741,6 +747,13 @@ var ReactCompositeComponentMixin = {
     nextUnmaskedContext
   ) {
     var inst = this._instance;
+    invariant(
+      inst != null,
+      'Attempted to update component `%s` that has already been unmounted ' +
+      '(or failed to mount).',
+      this.getName() || 'ReactCompositeComponent'
+    );
+
     var willReceive = false;
     var nextContext;
     var nextProps;