Skip to content

Commit

Permalink
Remove ReactDOMInstrumentation (#7481)
Browse files Browse the repository at this point in the history
Its events are not being used anywhere.
(cherry picked from commit cba2b19)
  • Loading branch information
gaearon authored and zpao committed Aug 12, 2016
1 parent 6a99238 commit 9d7ceac
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 181 deletions.
9 changes: 9 additions & 0 deletions src/renderers/dom/ReactDOM.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,13 @@ if (__DEV__) {
}
}

if (__DEV__) {
var ReactInstrumentation = require('ReactInstrumentation');
var ReactDOMUnknownPropertyHook = require('ReactDOMUnknownPropertyHook');
var ReactDOMNullInputValuePropHook = require('ReactDOMNullInputValuePropHook');

ReactInstrumentation.debugTool.addHook(ReactDOMUnknownPropertyHook);
ReactInstrumentation.debugTool.addHook(ReactDOMNullInputValuePropHook);
}

module.exports = ReactDOM;
7 changes: 0 additions & 7 deletions src/renderers/dom/shared/DOMPropertyOperations.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

var DOMProperty = require('DOMProperty');
var ReactDOMComponentTree = require('ReactDOMComponentTree');
var ReactDOMInstrumentation = require('ReactDOMInstrumentation');
var ReactInstrumentation = require('ReactInstrumentation');

var quoteAttributeValueForBrowser = require('quoteAttributeValueForBrowser');
Expand Down Expand Up @@ -89,9 +88,6 @@ var DOMPropertyOperations = {
* @return {?string} Markup string, or null if the property was invalid.
*/
createMarkupForProperty: function(name, value) {
if (__DEV__) {
ReactDOMInstrumentation.debugTool.onCreateMarkupForProperty(name, value);
}
var propertyInfo = DOMProperty.properties.hasOwnProperty(name) ?
DOMProperty.properties[name] : null;
if (propertyInfo) {
Expand Down Expand Up @@ -168,7 +164,6 @@ var DOMPropertyOperations = {
}

if (__DEV__) {
ReactDOMInstrumentation.debugTool.onSetValueForProperty(node, name, value);
var payload = {};
payload[name] = value;
ReactInstrumentation.debugTool.onHostOperation(
Expand Down Expand Up @@ -209,7 +204,6 @@ var DOMPropertyOperations = {
deleteValueForAttribute: function(node, name) {
node.removeAttribute(name);
if (__DEV__) {
ReactDOMInstrumentation.debugTool.onDeleteValueForProperty(node, name);
ReactInstrumentation.debugTool.onHostOperation(
ReactDOMComponentTree.getInstanceFromNode(node)._debugID,
'remove attribute',
Expand Down Expand Up @@ -246,7 +240,6 @@ var DOMPropertyOperations = {
}

if (__DEV__) {
ReactDOMInstrumentation.debugTool.onDeleteValueForProperty(node, name);
ReactInstrumentation.debugTool.onHostOperation(
ReactDOMComponentTree.getInstanceFromNode(node)._debugID,
'remove attribute',
Expand Down
78 changes: 0 additions & 78 deletions src/renderers/dom/shared/ReactDOMDebugTool.js

This file was deleted.

21 changes: 0 additions & 21 deletions src/renderers/dom/shared/ReactDOMInstrumentation.js

This file was deleted.

75 changes: 0 additions & 75 deletions src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js

This file was deleted.

0 comments on commit 9d7ceac

Please sign in to comment.