Skip to content

Commit

Permalink
Remove ReactFabricPublicInstance and used definition from ReactNative…
Browse files Browse the repository at this point in the history
…PrivateInterface (#26437)

## Summary

Now that React Native owns the definition for public instances in Fabric
and ReactNativePrivateInterface provides the methods to create instances
and access private fields (see
facebook/react-native#36570), we can remove the
definitions from React.

After this PR, React Native public instances will be opaque types for
React and it will only handle their creation but not their definition.
This will make RN similar to DOM in how public instances are handled.

This is a new version of #26418 which was closed without merging.

## How did you test this change?

* Existing tests.
* Manually synced the changes in this PR to React Native and tested it
end to end in Meta's infra.

DiffTrain build for commit 9c54b29.
  • Loading branch information
rubennorte committed Mar 23, 2023
1 parent b87cdfd commit 9dca7fd
Show file tree
Hide file tree
Showing 13 changed files with 20,783 additions and 21,076 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23649,7 +23649,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-f77099b6f-20230322";
var ReactVersion = "18.3.0-next-9c54b29b4-20230322";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8570,7 +8570,7 @@ var devToolsConfig$jscomp$inline_1029 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-f77099b6f-20230322",
version: "18.3.0-next-9c54b29b4-20230322",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1217 = {
Expand Down Expand Up @@ -8601,7 +8601,7 @@ var internals$jscomp$inline_1217 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-f77099b6f-20230322"
reconcilerVersion: "18.3.0-next-9c54b29b4-20230322"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1218 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8995,7 +8995,7 @@ var devToolsConfig$jscomp$inline_1072 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-f77099b6f-20230322",
version: "18.3.0-next-9c54b29b4-20230322",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1258 = {
Expand Down Expand Up @@ -9026,7 +9026,7 @@ var internals$jscomp$inline_1258 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-f77099b6f-20230322"
reconcilerVersion: "18.3.0-next-9c54b29b4-20230322"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1259 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-next-f77099b6f-20230322";
var ReactVersion = "18.3.0-next-9c54b29b4-20230322";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-f77099b6f-20230322";
exports.version = "18.3.0-next-9c54b29b4-20230322";
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-f77099b6f-20230322";
exports.version = "18.3.0-next-9c54b29b4-20230322";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f77099b6f1ccc658eff3467c6b9337e1b77ec854
9c54b29b44d24f8f8090da9c7ebf569747a444df
Loading

0 comments on commit 9dca7fd

Please sign in to comment.