Skip to content

Commit

Permalink
[Fiber] Move runWithFiberInDEV from CommitWork to CommitEffects (#30882)
Browse files Browse the repository at this point in the history
Stacked on #30881.

Move `runWithFiberInDEV` from the recursive part of the commit phase and
instead wrap each call into user space. These should really map 1:1 with
where we're using `try/catch` since that's where we're calling into user
space.

The goal of this is to avoid the extra stack frames added by
`enableOwnerStacks` in the recursive parts to avoid stack overflow. This
way we only have a couple of extra at the end of the stack instead of a
couple of extra at every depth of the tree.
  • Loading branch information
sebmarkbage authored Sep 6, 2024
1 parent fe03c56 commit a03254b
Show file tree
Hide file tree
Showing 4 changed files with 386 additions and 251 deletions.
Loading

0 comments on commit a03254b

Please sign in to comment.