Keep fastAddProperties only in ReactNativeAttributePayloadFabric

facebook · May 7, 2024 · ad43eec · ad43eec
1 parent 573c608
commit ad43eec
Showing 1 changed file with 2 additions and 68 deletions.
diff --git a/packages/react-native-renderer/src/ReactNativeAttributePayload.js b/packages/react-native-renderer/src/ReactNativeAttributePayload.js
@@ -15,7 +15,6 @@ import {
 import isArray from 'shared/isArray';
 
 import {enableEarlyReturnForPropDiffing} from 'shared/ReactFeatureFlags';
-import {enableAddPropertiesFastPath} from 'shared/ReactFeatureFlags';
 
 import type {AttributeConfiguration} from './ReactNativeTypes';
 
@@ -445,68 +444,6 @@ function diffProperties(
   return updatePayload;
 }
 
-function fastAddProperties(
-  updatePayload: null | Object,
-  nextProps: Object,
-  validAttributes: AttributeConfiguration,
-): null | Object {
-  let attributeConfig;
-  let nextProp;
-
-  for (const propKey in nextProps) {
-    nextProp = nextProps[propKey];
-
-    if (nextProp === undefined) {
-      continue;
-    }
-
-    attributeConfig = validAttributes[propKey];
-
-    if (attributeConfig === undefined) {
-      continue;
-    }
-
-    if (typeof nextProp === 'function') {
-      nextProp = (true: any);
-    }
-
-    if (typeof attributeConfig !== 'object') {
-      if (!updatePayload) {
-        updatePayload = ({}: {[string]: $FlowFixMe});
-      }
-      updatePayload[propKey] = nextProp;
-      continue;
-    }
-
-    if (typeof attributeConfig.process === 'function') {
-      if (!updatePayload) {
-        updatePayload = ({}: {[string]: $FlowFixMe});
-      }
-      updatePayload[propKey] = attributeConfig.process(nextProp);
-      continue;
-    }
-
-    if (isArray(nextProp)) {
-      for (let i = 0; i < nextProp.length; i++) {
-        updatePayload = fastAddProperties(
-          updatePayload,
-          nextProp[i],
-          ((attributeConfig: any): AttributeConfiguration),
-        );
-      }
-      continue;
-    }
-
-    updatePayload = fastAddProperties(
-      updatePayload,
-      nextProp,
-      ((attributeConfig: any): AttributeConfiguration),
-    );
-  }
-
-  return updatePayload;
-}
-
 /**
  * addProperties adds all the valid props to the payload after being processed.
  */
@@ -515,11 +452,8 @@ function addProperties(
   props: Object,
   validAttributes: AttributeConfiguration,
 ): null | Object {
-  if (enableAddPropertiesFastPath) {
-    return fastAddProperties(updatePayload, props, validAttributes);
-  } else {
-    return diffProperties(updatePayload, emptyObject, props, validAttributes);
-  }
+  // TODO: Fast path
+  return diffProperties(updatePayload, emptyObject, props, validAttributes);
 }
 
 /**