rename warning function

facebook · Jan 31, 2022 · bc1ca2a · bc1ca2a
1 parent 3cc0d1a
commit bc1ca2a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCompleteWork.new.js b/packages/react-reconciler/src/ReactFiberCompleteWork.new.js
@@ -130,7 +130,7 @@ import {
   popHydrationState,
   resetHydrationState,
   getIsHydrating,
-  hasMore,
+  hasUnhydratedTailNodes,
 } from './ReactFiberHydrationContext.new';
 import {
   enableSuspenseCallback,
@@ -1032,6 +1032,7 @@ function completeWork(
         if (
           enableClientRenderFallbackOnHydrationMismatch &&
           hasMore() &&
+          (workInProgress.mode & ConcurrentMode) !== NoMode &&
           (workInProgress.flags & DidCapture) === NoFlags
         ) {
           warnDeleteNextHydratableInstance(workInProgress);

diff --git a/packages/react-reconciler/src/ReactFiberHydrationContext.new.js b/packages/react-reconciler/src/ReactFiberHydrationContext.new.js
@@ -127,7 +127,7 @@ function reenterHydrationStateFromDehydratedSuspenseInstance(
   return true;
 }
 
-function warnDeleteHydratableInstance(
+function warnUnhydratedInstance(
   returnFiber: Fiber,
   instance: HydratableInstance,
 ) {
@@ -163,7 +163,7 @@ function deleteHydratableInstance(
   returnFiber: Fiber,
   instance: HydratableInstance,
 ) {
-  warnDeleteHydratableInstance(returnFiber, instance);
+  warnUnhydratedInstance(returnFiber, instance);
   const childToDelete = createFiberFromHostInstanceForDeletion();
   childToDelete.stateNode = instance;
   childToDelete.return = returnFiber;
@@ -572,13 +572,13 @@ function popHydrationState(fiber: Fiber): boolean {
   return true;
 }
 
-function hasMore() {
+function hasUnhydratedTailNodes() {
   return isHydrating && nextHydratableInstance !== null;
 }
 
 function warnDeleteNextHydratableInstance(fiber: Fiber) {
   if (nextHydratableInstance) {
-    warnDeleteHydratableInstance(fiber, nextHydratableInstance);
+    warnUnhydratedInstance(fiber, nextHydratableInstance);
   }
 }
 

diff --git a/packages/react-reconciler/src/ReactFiberHydrationContext.old.js b/packages/react-reconciler/src/ReactFiberHydrationContext.old.js
@@ -127,7 +127,7 @@ function reenterHydrationStateFromDehydratedSuspenseInstance(
   return true;
 }
 
-function warnDeleteHydratableInstance(
+function warnUnhydratedInstance(
   returnFiber: Fiber,
   instance: HydratableInstance,
 ) {
@@ -163,7 +163,7 @@ function deleteHydratableInstance(
   returnFiber: Fiber,
   instance: HydratableInstance,
 ) {
-  warnDeleteHydratableInstance(returnFiber, instance);
+  warnUnhydratedInstance(returnFiber, instance);
   const childToDelete = createFiberFromHostInstanceForDeletion();
   childToDelete.stateNode = instance;
   childToDelete.return = returnFiber;
@@ -578,7 +578,7 @@ function hasMore() {
 
 function warnDeleteNextHydratableInstance(fiber: Fiber) {
   if (nextHydratableInstance) {
-    warnDeleteHydratableInstance(fiber, nextHydratableInstance);
+    warnUnhydratedInstance(fiber, nextHydratableInstance);
   }
 }