Add html_all_collection type to correct typeof document.all

facebook · Aug 14, 2020 · c560e93 · c560e93
1 parent 2704bb5
commit c560e93
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/packages/react-devtools-shared/src/hydration.js b/packages/react-devtools-shared/src/hydration.js
@@ -219,6 +219,7 @@ export function dehydrate(
         ),
       );
 
+    case 'html_all_collection':
     case 'typed_array':
     case 'iterator':
       isPathAllowedCheck = isPathAllowed(path);

diff --git a/packages/react-devtools-shared/src/utils.js b/packages/react-devtools-shared/src/utils.js
@@ -372,6 +372,7 @@ export type DataType =
   | 'data_view'
   | 'date'
   | 'function'
+  | 'html_all_collection'
   | 'html_element'
   | 'infinity'
   | 'iterator'
@@ -447,6 +448,9 @@ export function getDataType(data: Object): DataType {
     case 'symbol':
       return 'symbol';
     default:
+      if (data instanceof HTMLAllCollection) {
+        return 'html_all_collection';
+      }
       return 'unknown';
   }
 }