-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DevTools] Unmount instance by walking the instance tree instead of t…
…he fiber tree (#30665) There was a comment that it's not safe to walk the unmounted fiber tree which I'm not sure is correct or not but we need to walk the instance tree to be able to clean up virtual instances anyway. We already walk the instance tree to clean up "remaining instances". This is also simpler because we don't need to special case Suspense boundaries. We simply clean up whatever branch we had before. The ultimate goal is to also walk the instance tree for updates so we don't need a fiber to instance map.
- Loading branch information
1 parent
d48603a
commit e865fe0
Showing
1 changed file
with
35 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters