Skip to content

Commit

Permalink
Fix and update attribute-behavior fixture (#26114)
Browse files Browse the repository at this point in the history
## Summary

Due to #25928 the attribute
fixture could no longer finish since it expects at least something to
render. But since Fizz currently breaks down completely on malformed
`<meta>` tags, the fixture could no longer handle this.

The fixture now renders valid types for `meta` tags.

Note that the snapshot change to `viewTarget`` is already on `main`.
Review by commit helps to understand this.

Added `html[lang]` so that we test at least one standard attribute on
`<html>`. `version` is obsolete so results are not that trustworthy.

## How did you test this change?

With Chrome Version 109.0.5414.119 (Official Build) (64-bit)

- `yarn build --type=UMD_DEV react/index,react-dom && cd
fixtures/attribute-behavior && yarn install && yarn start`

DiffTrain build for [b8ae89f](b8ae89f)
[View git log for this commit](https://github.com/facebook/react/commits/b8ae89f38288bfae37dff54fa1ec4bf3b4555ed5)
  • Loading branch information
eps1lon committed Feb 10, 2023
1 parent 5d94a68 commit ec5f59a
Show file tree
Hide file tree
Showing 28 changed files with 42 additions and 42 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d9e0485c84b45055ba86629dc20870faca9b5973
b8ae89f38288bfae37dff54fa1ec4bf3b4555ed5
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d9e0485c84b45055ba86629dc20870faca9b5973
b8ae89f38288bfae37dff54fa1ec4bf3b4555ed5
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-classic-b8ae89f38-20230210";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-modern-b8ae89f38-20230210";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-d9e0485c8-20230210";
exports.version = "18.3.0-www-classic-b8ae89f38-20230210";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-d9e0485c8-20230210";
exports.version = "18.3.0-www-modern-b8ae89f38-20230210";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-d9e0485c8-20230210";
exports.version = "18.3.0-www-classic-b8ae89f38-20230210";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-d9e0485c8-20230210";
exports.version = "18.3.0-www-modern-b8ae89f38-20230210";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-classic-b8ae89f38-20230210";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-modern-b8ae89f38-20230210";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9844,7 +9844,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-d9e0485c8-20230210",
version: "18.3.0-www-classic-b8ae89f38-20230210",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1318 = {
Expand Down Expand Up @@ -9875,7 +9875,7 @@ var internals$jscomp$inline_1318 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9509,7 +9509,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-d9e0485c8-20230210",
version: "18.3.0-www-modern-b8ae89f38-20230210",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1309 = {
Expand Down Expand Up @@ -9540,7 +9540,7 @@ var internals$jscomp$inline_1309 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -41950,7 +41950,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-classic-b8ae89f38-20230210";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -41674,7 +41674,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-modern-b8ae89f38-20230210";

function createPortal(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15433,7 +15433,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1743 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-d9e0485c8-20230210",
version: "18.3.0-www-classic-b8ae89f38-20230210",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2106 = {
Expand Down Expand Up @@ -15463,7 +15463,7 @@ var internals$jscomp$inline_2106 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2107 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15711,4 +15711,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-d9e0485c8-20230210";
exports.version = "18.3.0-next-b8ae89f38-20230210";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -14993,7 +14993,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1711 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-d9e0485c8-20230210",
version: "18.3.0-www-modern-b8ae89f38-20230210",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2081 = {
Expand Down Expand Up @@ -15024,7 +15024,7 @@ var internals$jscomp$inline_2081 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2082 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15212,4 +15212,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-d9e0485c8-20230210";
exports.version = "18.3.0-next-b8ae89f38-20230210";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16203,7 +16203,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1817 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-d9e0485c8-20230210",
version: "18.3.0-www-classic-b8ae89f38-20230210",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16247,7 +16247,7 @@ var devToolsConfig$jscomp$inline_1817 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16482,7 +16482,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-d9e0485c8-20230210";
exports.version = "18.3.0-next-b8ae89f38-20230210";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15753,7 +15753,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1785 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-d9e0485c8-20230210",
version: "18.3.0-www-modern-b8ae89f38-20230210",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -15798,7 +15798,7 @@ var devToolsConfig$jscomp$inline_1785 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -15973,7 +15973,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-d9e0485c8-20230210";
exports.version = "18.3.0-next-b8ae89f38-20230210";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-classic-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-classic-b8ae89f38-20230210";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-modern-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-modern-b8ae89f38-20230210";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3653,4 +3653,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-d9e0485c8-20230210";
exports.version = "18.3.0-www-classic-b8ae89f38-20230210";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3561,4 +3561,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-d9e0485c8-20230210";
exports.version = "18.3.0-www-modern-b8ae89f38-20230210";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31317,7 +31317,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-classic-b8ae89f38-20230210";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -37769,7 +37769,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-modern-b8ae89f38-20230210";

function createPortal(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -11553,7 +11553,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1538 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-d9e0485c8-20230210",
version: "18.3.0-www-classic-b8ae89f38-20230210",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2057 = {
Expand Down Expand Up @@ -11583,7 +11583,7 @@ var internals$jscomp$inline_2057 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2058 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14761,4 +14761,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-d9e0485c8-20230210";
exports.version = "18.3.0-next-b8ae89f38-20230210";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -13868,7 +13868,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1666 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-d9e0485c8-20230210",
version: "18.3.0-www-modern-b8ae89f38-20230210",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2044 = {
Expand Down Expand Up @@ -13899,7 +13899,7 @@ var internals$jscomp$inline_2044 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-d9e0485c8-20230210"
reconcilerVersion: "18.3.0-next-b8ae89f38-20230210"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2045 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14230,4 +14230,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-d9e0485c8-20230210";
exports.version = "18.3.0-next-b8ae89f38-20230210";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -23913,7 +23913,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-classic-b8ae89f38-20230210";

// Might add PROFILE later.

Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -23913,7 +23913,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-d9e0485c8-20230210";
var ReactVersion = "18.3.0-www-modern-b8ae89f38-20230210";

// Might add PROFILE later.

Expand Down

0 comments on commit ec5f59a

Please sign in to comment.