Skip to content

Commit

Permalink
Fix Overlapping "message" Bug in Performance Track (#31528)
Browse files Browse the repository at this point in the history
When you schedule a microtask from render or effect and then call
setState (or ping) from there, the "event" is the event that React
scheduled (which will be a postMessage). The event time of this new
render will be before the last render finished.

We usually clamp these but in this scenario the update doesn't happen
while a render is happening. Causing overlapping events.

Before:

<img width="1229" alt="Screenshot 2024-11-12 at 11 01 30 PM"
src="https://github.com/user-attachments/assets/9652cf3b-b358-453c-b295-1239cbb15952">

Therefore when we finalize a render we need to store the end of the last
render so when we a new update comes in later with an event time earlier
than that, we know to clamp it.

There's also a special case here where when we enter the
`RootDidNotComplete` or `RootSuspendedWithDelay` case we neither leave
the root as in progress nor commit it. Those needs to finalize too.
Really this should be modeled as a suspended track that we haven't added
yet. That's the gap between "Blocked" and "message" below.

After:

<img width="1471" alt="Screenshot 2024-11-13 at 12 31 34 AM"
src="https://github.com/user-attachments/assets/b24f994e-9055-4b10-ad29-ad9b36302ffc">

I also fixed an issue where we may log the same event name multiple
times if we're rendering more than once in the same event. In this case
I just leave a blank trace between the last commit and the next update.

I also adding ignoring of the "message" event at all in these cases when
the event is from React's scheduling itself.

DiffTrain build for [c13986d](c13986d)
  • Loading branch information
sebmarkbage committed Nov 14, 2024
1 parent e7777dc commit ed85198
Show file tree
Hide file tree
Showing 34 changed files with 90 additions and 86 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7aa5dda3b3e4c2baa905a59b922ae7ec14734b24
c13986da7866a1a70a73b7ee05c87a9618ce6d03
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7aa5dda3b3e4c2baa905a59b922ae7ec14734b24
c13986da7866a1a70a73b7ee05c87a9618ce6d03
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1819,7 +1819,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1819,7 +1819,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -619,4 +619,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -619,4 +619,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16717,11 +16717,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-988e2176-20241114",
version: "19.0.0-www-classic-c13986da-20241114",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-988e2176-20241114"
reconcilerVersion: "19.0.0-www-classic-c13986da-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16755,7 +16755,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16480,11 +16480,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-988e2176-20241114",
version: "19.0.0-www-modern-c13986da-20241114",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-988e2176-20241114"
reconcilerVersion: "19.0.0-www-modern-c13986da-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16518,7 +16518,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10634,13 +10634,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1471 = {
bundleType: 0,
version: "19.0.0-www-classic-988e2176-20241114",
version: "19.0.0-www-classic-c13986da-20241114",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-classic-988e2176-20241114"
reconcilerVersion: "19.0.0-www-classic-c13986da-20241114"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1472 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10666,4 +10666,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10350,13 +10350,13 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1450 = {
bundleType: 0,
version: "19.0.0-www-modern-988e2176-20241114",
version: "19.0.0-www-modern-c13986da-20241114",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: function () {
return null;
},
reconcilerVersion: "19.0.0-www-modern-988e2176-20241114"
reconcilerVersion: "19.0.0-www-modern-c13986da-20241114"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1451 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10382,4 +10382,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27137,11 +27137,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-www-classic-988e2176-20241114" !== isomorphicReactPackageVersion)
if ("19.0.0-www-classic-c13986da-20241114" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-www-classic-988e2176-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-www-classic-c13986da-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27184,11 +27184,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-classic-988e2176-20241114",
version: "19.0.0-www-classic-c13986da-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-988e2176-20241114"
reconcilerVersion: "19.0.0-www-classic-c13986da-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -27793,7 +27793,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -26916,11 +26916,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-www-modern-988e2176-20241114" !== isomorphicReactPackageVersion)
if ("19.0.0-www-modern-c13986da-20241114" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-www-modern-988e2176-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-www-modern-c13986da-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -26963,11 +26963,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-www-modern-988e2176-20241114",
version: "19.0.0-www-modern-c13986da-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-988e2176-20241114"
reconcilerVersion: "19.0.0-www-modern-c13986da-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -27572,7 +27572,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17061,14 +17061,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1741 = React.version;
if (
"19.0.0-www-classic-988e2176-20241114" !==
"19.0.0-www-classic-c13986da-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1741
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1741,
"19.0.0-www-classic-988e2176-20241114"
"19.0.0-www-classic-c13986da-20241114"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17086,11 +17086,11 @@ Internals.Events = [
];
var internals$jscomp$inline_2285 = {
bundleType: 0,
version: "19.0.0-www-classic-988e2176-20241114",
version: "19.0.0-www-classic-c13986da-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-988e2176-20241114"
reconcilerVersion: "19.0.0-www-classic-c13986da-20241114"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2286 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17453,4 +17453,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16792,14 +16792,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1731 = React.version;
if (
"19.0.0-www-modern-988e2176-20241114" !==
"19.0.0-www-modern-c13986da-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1731
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1731,
"19.0.0-www-modern-988e2176-20241114"
"19.0.0-www-modern-c13986da-20241114"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -16817,11 +16817,11 @@ Internals.Events = [
];
var internals$jscomp$inline_2267 = {
bundleType: 0,
version: "19.0.0-www-modern-988e2176-20241114",
version: "19.0.0-www-modern-c13986da-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-988e2176-20241114"
reconcilerVersion: "19.0.0-www-modern-c13986da-20241114"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2268 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17184,4 +17184,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17751,14 +17751,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1834 = React.version;
if (
"19.0.0-www-classic-988e2176-20241114" !==
"19.0.0-www-classic-c13986da-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1834
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1834,
"19.0.0-www-classic-988e2176-20241114"
"19.0.0-www-classic-c13986da-20241114"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17776,11 +17776,11 @@ Internals.Events = [
];
var internals$jscomp$inline_1836 = {
bundleType: 0,
version: "19.0.0-www-classic-988e2176-20241114",
version: "19.0.0-www-classic-c13986da-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-classic-988e2176-20241114"
reconcilerVersion: "19.0.0-www-classic-c13986da-20241114"
};
enableSchedulingProfiler &&
((internals$jscomp$inline_1836.getLaneLabelMap = getLaneLabelMap),
Expand Down Expand Up @@ -18146,7 +18146,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -17481,14 +17481,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1824 = React.version;
if (
"19.0.0-www-modern-988e2176-20241114" !==
"19.0.0-www-modern-c13986da-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1824
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1824,
"19.0.0-www-modern-988e2176-20241114"
"19.0.0-www-modern-c13986da-20241114"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17506,11 +17506,11 @@ Internals.Events = [
];
var internals$jscomp$inline_1826 = {
bundleType: 0,
version: "19.0.0-www-modern-988e2176-20241114",
version: "19.0.0-www-modern-c13986da-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-www-modern-988e2176-20241114"
reconcilerVersion: "19.0.0-www-modern-c13986da-20241114"
};
enableSchedulingProfiler &&
((internals$jscomp$inline_1826.getLaneLabelMap = getLaneLabelMap),
Expand Down Expand Up @@ -17876,7 +17876,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -8991,5 +8991,5 @@ __DEV__ &&
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
})();
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -8809,5 +8809,5 @@ __DEV__ &&
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
})();
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -5910,4 +5910,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.0.0-www-classic-988e2176-20241114";
exports.version = "19.0.0-www-classic-c13986da-20241114";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -5822,4 +5822,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.0.0-www-modern-988e2176-20241114";
exports.version = "19.0.0-www-modern-c13986da-20241114";
Loading

0 comments on commit ed85198

Please sign in to comment.