Skip to content

Commit

Permalink
[DevTools] permanently polyfill for rAF in devtools_page (#26193)
Browse files Browse the repository at this point in the history
## Summary

We had this as a temporary fix for #24626. Now that Chrome team decides
to turn the flag on again (with good reasons explained in
https://bugs.chromium.org/p/chromium/issues/detail?id=1241986#c31), we
will turn it into a long term solution.
In the future, we want to explore whether we can render React elements
on panel.html instead, as `requestAnimationFrame` produces higher
quality animation.

## How did you test this change?

Tested on local build with "Throttle non-visible cross-origin iframes"
flag enabled.

DiffTrain build for [ca2cf31](ca2cf31)
  • Loading branch information
mondaychen committed Feb 23, 2023
1 parent 56ece52 commit f007bf8
Show file tree
Hide file tree
Showing 28 changed files with 42 additions and 42 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bfb9cbd8ca2d042677056110887cc62d438f665f
ca2cf319fdfcf6e5f048e082f5169bc1b849c129
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bfb9cbd8ca2d042677056110887cc62d438f665f
ca2cf319fdfcf6e5f048e082f5169bc1b849c129
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-bfb9cbd8c-20230223";
exports.version = "18.3.0-www-classic-ca2cf319f-20230223";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-bfb9cbd8c-20230223";
exports.version = "18.3.0-www-modern-ca2cf319f-20230223";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-bfb9cbd8c-20230223";
exports.version = "18.3.0-www-classic-ca2cf319f-20230223";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-bfb9cbd8c-20230223";
exports.version = "18.3.0-www-modern-ca2cf319f-20230223";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9786,7 +9786,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-bfb9cbd8c-20230223",
version: "18.3.0-www-classic-ca2cf319f-20230223",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1301 = {
Expand Down Expand Up @@ -9817,7 +9817,7 @@ var internals$jscomp$inline_1301 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9451,7 +9451,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-bfb9cbd8c-20230223",
version: "18.3.0-www-modern-ca2cf319f-20230223",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1281 = {
Expand Down Expand Up @@ -9482,7 +9482,7 @@ var internals$jscomp$inline_1281 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -41990,7 +41990,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";

function createPortal$1(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -41594,7 +41594,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";

function createPortal$1(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15455,7 +15455,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1742 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bfb9cbd8c-20230223",
version: "18.3.0-www-classic-ca2cf319f-20230223",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2109 = {
Expand Down Expand Up @@ -15485,7 +15485,7 @@ var internals$jscomp$inline_2109 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15733,4 +15733,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bfb9cbd8c-20230223";
exports.version = "18.3.0-next-ca2cf319f-20230223";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -14984,7 +14984,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1701 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-bfb9cbd8c-20230223",
version: "18.3.0-www-modern-ca2cf319f-20230223",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2073 = {
Expand Down Expand Up @@ -15015,7 +15015,7 @@ var internals$jscomp$inline_2073 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15192,4 +15192,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bfb9cbd8c-20230223";
exports.version = "18.3.0-next-ca2cf319f-20230223";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16225,7 +16225,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1822 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bfb9cbd8c-20230223",
version: "18.3.0-www-classic-ca2cf319f-20230223",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16269,7 +16269,7 @@ var devToolsConfig$jscomp$inline_1822 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16504,7 +16504,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bfb9cbd8c-20230223";
exports.version = "18.3.0-next-ca2cf319f-20230223";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15744,7 +15744,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1781 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-bfb9cbd8c-20230223",
version: "18.3.0-www-modern-ca2cf319f-20230223",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -15789,7 +15789,7 @@ var devToolsConfig$jscomp$inline_1781 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -15953,7 +15953,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bfb9cbd8c-20230223";
exports.version = "18.3.0-next-ca2cf319f-20230223";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-classic-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-modern-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-bfb9cbd8c-20230223";
exports.version = "18.3.0-www-classic-ca2cf319f-20230223";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-bfb9cbd8c-20230223";
exports.version = "18.3.0-www-modern-ca2cf319f-20230223";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31227,7 +31227,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";

function createPortal$1(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -37618,7 +37618,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";

function createPortal$1(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -11527,7 +11527,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1536 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bfb9cbd8c-20230223",
version: "18.3.0-www-classic-ca2cf319f-20230223",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2059 = {
Expand Down Expand Up @@ -11557,7 +11557,7 @@ var internals$jscomp$inline_2059 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14735,4 +14735,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bfb9cbd8c-20230223";
exports.version = "18.3.0-next-ca2cf319f-20230223";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -13842,7 +13842,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1653 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-bfb9cbd8c-20230223",
version: "18.3.0-www-modern-ca2cf319f-20230223",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2033 = {
Expand Down Expand Up @@ -13873,7 +13873,7 @@ var internals$jscomp$inline_2033 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bfb9cbd8c-20230223"
reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14193,4 +14193,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bfb9cbd8c-20230223";
exports.version = "18.3.0-next-ca2cf319f-20230223";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -23743,7 +23743,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";

// Might add PROFILE later.

Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -23743,7 +23743,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-bfb9cbd8c-20230223";
var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";

// Might add PROFILE later.

Expand Down

0 comments on commit f007bf8

Please sign in to comment.