Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handleTopLevel can throw when removing event target #1105

Closed
sophiebits opened this issue Feb 17, 2014 · 0 comments · Fixed by #1106
Closed

handleTopLevel can throw when removing event target #1105

sophiebits opened this issue Feb 17, 2014 · 0 comments · Fixed by #1106
Milestone
0.9

Comments

@sophiebits
Copy link
Collaborator

This throws when you click the text:

http://jsbin.com/remixuxu/3/edit
@sophiebits sophiebits added this to the 0.9 milestone Feb 17, 2014
@sophiebits sophiebits mentioned this issue Feb 17, 2014
Merged
@plievone plievone mentioned this issue Feb 17, 2014
Closed
sophiebits added a commit to sophiebits/react that referenced this issue Feb 17, 2014
@sophiebits
Prevent error thrown when removing event target
2f0bb69 
Fixes facebook#1105.
petehunt added a commit that referenced this issue Feb 18, 2014
@petehunt
Merge pull request #1106 from spicyj/gh-1105
8ac5975 
Prevent error thrown when removing event target
@sophiebits sophiebits mentioned this issue Jun 23, 2015
Closed
gaearon pushed a commit that referenced this issue Nov 3, 2017
@enapupe @gaearon
Use only public api for ReactDOMEventListener-test.js (#11327)
bfa2690 
* Use only public api for ReactDOMEventListener-test.js

* Use less confusing naming

There was no need to extract React elements into separate variables.

* Replace the "disappearance" test

I could not get it to fail on master so it was probably testing something specific to Stack implementation details. It was also already broken because it didn't look at the right argument and never actually called `unmountComponentAtNode`.

Instead I replaced it with original repro case from #1105 which is when it was introduced.

* Tweak naming and add comments

* Missed this one
Ethan-Arrowood pushed a commit to Ethan-Arrowood/react that referenced this issue Dec 8, 2017
@enapupe @Ethan-Arrowood
Use only public api for ReactDOMEventListener-test.js (facebook#11327)
62cfb4d 
* Use only public api for ReactDOMEventListener-test.js

* Use less confusing naming

There was no need to extract React elements into separate variables.

* Replace the "disappearance" test

I could not get it to fail on master so it was probably testing something specific to Stack implementation details. It was also already broken because it didn't look at the right argument and never actually called `unmountComponentAtNode`.

Instead I replaced it with original repro case from facebook#1105 which is when it was introduced.

* Tweak naming and add comments

* Missed this one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging a pull request may close this issue.

Prevent error thrown when removing event target sophiebits/react
2 participants
@sophiebits @zpao