Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coalesce warnings for deprecated lifecycle hooks #12044

Closed
bvaughn opened this issue Jan 18, 2018 · 0 comments
Closed

Coalesce warnings for deprecated lifecycle hooks #12044

bvaughn opened this issue Jan 18, 2018 · 0 comments
Assignees
@bvaughn

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jan 18, 2018

Coalesce warnings for deprecated lifecycle hooks and print single message after reconciliation (rather than one per component-type).

Relates to PR #12028 and this comment.
@bvaughn bvaughn self-assigned this Jan 18, 2018
This was referenced Jan 18, 2018
Merged
Merged
Merged
bvaughn added a commit to bvaughn/react that referenced this issue Jan 25, 2018
@bvaughn
Coalesce lifecycle deprecation warnings until the commit phase
b6d9aa7 
Builds on top of PR facebook#12083 and resolves issue facebook#12044.

Coalesces deprecation warnings until the commit phase. This proposal extends the  utility introduced in facebook#12060 to also coalesce deprecation warnings.

New warning format will look like this:
> componentWillMount is deprecated and will be removed in the next major version. Use componentDidMount instead. As a temporary workaround, you can rename to UNSAFE_componentWillMount.
>
> Please update the following components: Foo, Bar
>
> Learn more about this warning here:
> https://fb.me/react-async-component-lifecycle-hooks
bvaughn added a commit that referenced this issue Jan 25, 2018
@bvaughn
Coalesce lifecycle deprecation warnings until the commit phase (#12084)
6dabfca 
Builds on top of PR #12083 and resolves issue #12044.

Coalesces deprecation warnings until the commit phase. This proposal extends the  utility introduced in #12060 to also coalesce deprecation warnings.

New warning format will look like this:
> componentWillMount is deprecated and will be removed in the next major version. Use componentDidMount instead. As a temporary workaround, you can rename to UNSAFE_componentWillMount.
>
> Please update the following components: Foo, Bar
>
> Learn more about this warning here:
> https://fb.me/react-async-component-lifecycle-hooks
@bvaughn bvaughn closed this as completed Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bvaughn