Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add find/scry by ID to test utils #1616

Closed
feifanzhou opened this issue May 28, 2014 · 1 comment
Closed

Add find/scry by ID to test utils #1616

feifanzhou opened this issue May 28, 2014 · 1 comment
Labels
Component: Test Utils

Comments

@feifanzhou
Copy link

TestUtils currently has scryRenderedDOMComponentsWithClass and the find variant, but nothing like findRenderedDOMComponentWithID. This functionality would make testing a lot easier.
@feifanzhou feifanzhou changed the title Add find/scry by id to test utils Add find/scry by ID to test utils May 28, 2014
chenglou added a commit to chenglou/react that referenced this issue Jun 6, 2014
@chenglou
Add TestUtils find/scry DOMComponent by prop
c3bb082 
Fixes facebook#1616, which asked for finding the ID. This is more general.
@chenglou chenglou mentioned this issue Jun 6, 2014
Closed
@taiansu taiansu mentioned this issue Apr 27, 2015
Closed
@sophiebits
Copy link
Collaborator

We're not planning to add more utils like this to TestUtils. You can always implement this locally in your project as a helper if you want to, but we're planning to move towards shallow testing (i.e., TestUtils. createRenderer) in the future.

@insidewhy insidewhy mentioned this issue Jul 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Utils
Projects
None yet
Milestone
No milestone
4 participants
@sophiebits @zpao @chenglou @feifanzhou