Bug: Normal update between Idle render and a Ping causes Fallback to get stuck #18657
Comments
gaearon
added
Status: Unconfirmed
acdlite
added a commit
to acdlite/react
that referenced
this issue
Apr 17, 2020
Merged
acdlite
added a commit
that referenced
this issue
Apr 17, 2020
* Failing test for #18657 * Remove incorrect priority check I think this was just poor factoring on my part in #18411. Honestly it doesn't make much sense to me, but my best guess is that I must have thought that when `baseTime > currentChildExpirationTime`, the function would fall through to the `currentChildExpirationTime < renderExpirationTime` branch below. Really I think just made an oopsie. Regardless, this logic is galaxy brainéd. A goal of the Lanes refactor I'm working on is to make these types of checks -- is there remaining work in this tree? -- a lot easier to think about. Hopefully.
Closed
dubzzz
added a commit
to dubzzz/react
that referenced
this issue
Apr 23, 2020
The current commit is totally work in progress but it already found back the issue by reporting the following counterexample:
```
[Scheduler`
-> [task#2] sequence::Scheduling "8" with priority 3 resolved
-> [task#1] promise::Request for "447b0ed" resolved with value "resolved 447b0ed!"`,"447b0ed",[{"priority":3,"text":"8"}],<function :: ["447b0ed"] => true, ["8"] => true>]
```
Reproduced by https://codesandbox.io/s/strange-frost-d4ujl?file=/src/App.js
Related to facebook#18669
dubzzz
added a commit
to dubzzz/react
that referenced
this issue
Apr 23, 2020
The current commit is totally work in progress but it already found back the issue by reporting the following counterexample:
```
[Scheduler`
-> [task#2] sequence::Scheduling "8" with priority 3 resolved
-> [task#1] promise::Request for "447b0ed" resolved with value "resolved 447b0ed!"`,"447b0ed",[{"priority":3,"text":"8"}],<function :: ["447b0ed"] => true, ["8"] => true>]
```
Reproduced by https://codesandbox.io/s/strange-frost-d4ujl?file=/src/App.js
Related to facebook#18669
dubzzz
added a commit
to dubzzz/react
that referenced
this issue
Apr 23, 2020
It would actually have detected the issue facebook#18657. It found the following counterexample: ``` [Scheduler` -> [task#2] sequence::Scheduling "8" with priority 3 resolved -> [task#1] promise::Request for "447b0ed" resolved with value "resolved 447b0ed!"`,"447b0ed",[{"priority":3,"text":"8"}],<function :: ["447b0ed"] => true, ["8"] => true>] ``` Reproduced by https://codesandbox.io/s/strange-frost-d4ujl?file=/src/App.js Related to facebook#18669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro case with a master build: https://codesandbox.io/s/stoic-mcnulty-dhygf?file=/src/App.js:668-703
Expected: we see content after a second.
Actual: fallback never resolves.
This happens in a sequence of:
If you remove
_setVersion(v => v + 1);on line 44 then the issue goes away.The text was updated successfully, but these errors were encountered: