Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - MyComponent() does not create component instance #2179

Closed
ghost23 opened this issue Sep 11, 2014 · 1 comment · Fixed by #2180
Closed

docs - MyComponent() does not create component instance #2179

ghost23 opened this issue Sep 11, 2014 · 1 comment · Fixed by #2180

Comments

@ghost23
Copy link

ghost23 commented Sep 11, 2014

Hi,

in the docs here:

https://github.com/facebook/react/blob/master/docs/docs/ref-02-component-api.md#reactcomponent

it says, that:

"Component classes created by React.createClass() return instances of ReactComponent when called".

But it turns out, React.renderComponent(...) actually creates the component instance, at least the one you work with. I think, the docs should reflect that.

@zpao
Copy link
Member

zpao commented Sep 11, 2014

Good catch. We updated a lot of other places as we evolved the API but obviously missed at least one. Let us know if you see any more!

zpao added a commit to zpao/react that referenced this issue Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants