-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs Rake "update_version" command to strip trailing spaces #24
Comments
zpao
added a commit
that referenced
this issue
May 30, 2013
Doesn't fix, but mostly addresses the concerns in #24. Some churn at version bumps is far better than what we have right now.
I changed this to only rewrite the file on version bumps in de2832c, so I'm going to call it good enough and close this out. |
steveluscher
pushed a commit
that referenced
this issue
Nov 25, 2014
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like it's mostly a problem with Ruby 1.8 yaml vs 1.9 yaml. One strips the trailing space and the other leaves it in.
There's also the issue of reordering. So at the very least we shouldn't re-write _config.yml if the version is the same.
The text was updated successfully, but these errors were encountered: