Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: broken link in react-reconciler #25716

Closed
xfq opened this issue Nov 21, 2022 · 1 comment
Closed

Bug: broken link in react-reconciler #25716

xfq opened this issue Nov 21, 2022 · 1 comment
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@xfq
Copy link

xfq commented Nov 21, 2022

React version: main branch

Steps To Reproduce

  1. Open https://github.com/facebook/react/blob/main/packages/react-reconciler/README.md#practical-examples
  2. Click "host config" in "React DOM and its host config"

The current behavior

The page is 404.

The expected behavior

The page should exist.
@xfq xfq added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Nov 21, 2022
@h4x0rlol h4x0rlol mentioned this issue Dec 2, 2022
Merged
gaearon pushed a commit that referenced this issue Dec 2, 2022
@h4x0rlol
fix link to ReactDOMHostconfig in reconciler docs (#25788)
7fab379 
## Summary

Reference to #25716, changed old link to a new, now page exist, instead
of 404.

## How did you test this change?

yarn test
and by clicking on the link of host config in
https://github.com/facebook/react/blob/main/packages/react-reconciler/README.md#practical-examples
@kassens
Copy link
Member

kassens commented Dec 9, 2022

Fixed by #25788

@kassens kassens closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kassens @xfq